| Message ID | 20230105100548.18155-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | c15ff6b59de877ab8ee19b09e9315e5eaffdb818 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Laurent Pinchart via libcamera-devel (2023-01-05 10:05:48) > Meson has deprecated implicit usage of the setup command. Update the > build instructions to use 'meson setup' explicitly. Is there a reference somewhere that states this is deprecated? I haven't seen one and can't (quickly) find it. But it's fine either way, this is still the 'correct' way to do it Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > README.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.rst b/README.rst > index e9dd4207ae55..34b6b49f3575 100644 > --- a/README.rst > +++ b/README.rst > @@ -34,7 +34,7 @@ To fetch the sources, build and install: > > git clone https://git.libcamera.org/libcamera/libcamera.git > cd libcamera > - meson build > + meson setup build > ninja -C build install > > Dependencies > > base-commit: e1b81401cafa2e071b0903c0afe8363e84c11ede > -- > Regards, > > Laurent Pinchart >
On Thu, Jan 05, 2023 at 02:14:53PM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart via libcamera-devel (2023-01-05 10:05:48) > > Meson has deprecated implicit usage of the setup command. Update the > > build instructions to use 'meson setup' explicitly. > > Is there a reference somewhere that states this is deprecated? I haven't > seen one and can't (quickly) find it. It's printed by meson: WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. I'll add that to the commit message. > But it's fine either way, this is still the 'correct' way to do it > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > README.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.rst b/README.rst > > index e9dd4207ae55..34b6b49f3575 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -34,7 +34,7 @@ To fetch the sources, build and install: > > > > git clone https://git.libcamera.org/libcamera/libcamera.git > > cd libcamera > > - meson build > > + meson setup build > > ninja -C build install > > > > Dependencies > > > > base-commit: e1b81401cafa2e071b0903c0afe8363e84c11ede
diff --git a/README.rst b/README.rst index e9dd4207ae55..34b6b49f3575 100644 --- a/README.rst +++ b/README.rst @@ -34,7 +34,7 @@ To fetch the sources, build and install: git clone https://git.libcamera.org/libcamera/libcamera.git cd libcamera - meson build + meson setup build ninja -C build install Dependencies
Meson has deprecated implicit usage of the setup command. Update the build instructions to use 'meson setup' explicitly. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e1b81401cafa2e071b0903c0afe8363e84c11ede