[libcamera-devel,v9,11/18] lc-compliance: Fix source file ordering in meson.build
diff mbox series

Message ID 20221216122939.256534-12-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • lc-compliance: Add test to queue more requests than hardware depth
Related show

Commit Message

Paul Elder Dec. 16, 2022, 12:29 p.m. UTC
From: Nícolas F. R. A. Prado <nfraprado@collabora.com>

The capture_test.cpp file was added in the source list of meson in the
wrong place. Fix it so the list is alphabetically sorted.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

---
Changes in v9:
- rebased

Changes in v8:
- New
---
 src/apps/lc-compliance/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Umang Jain Dec. 21, 2022, 10:50 a.m. UTC | #1
Hi Paul,

Thank you for the patch

On 12/16/22 5:59 PM, Paul Elder via libcamera-devel wrote:
> From: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> The capture_test.cpp file was added in the source list of meson in the
> wrong place. Fix it so the list is alphabetically sorted.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

>
> ---
> Changes in v9:
> - rebased
>
> Changes in v8:
> - New
> ---
>   src/apps/lc-compliance/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build
> index 51d9075a..3b1927fd 100644
> --- a/src/apps/lc-compliance/meson.build
> +++ b/src/apps/lc-compliance/meson.build
> @@ -11,10 +11,10 @@ endif
>   lc_compliance_enabled = true
>   
>   lc_compliance_sources = files([
> +    'capture_test.cpp',
>       'environment.cpp',
>       'main.cpp',
>       'simple_capture.cpp',
> -    'capture_test.cpp',
>   ])
>   
>   lc_compliance  = executable('lc-compliance', lc_compliance_sources,

Patch
diff mbox series

diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build
index 51d9075a..3b1927fd 100644
--- a/src/apps/lc-compliance/meson.build
+++ b/src/apps/lc-compliance/meson.build
@@ -11,10 +11,10 @@  endif
 lc_compliance_enabled = true
 
 lc_compliance_sources = files([
+    'capture_test.cpp',
     'environment.cpp',
     'main.cpp',
     'simple_capture.cpp',
-    'capture_test.cpp',
 ])
 
 lc_compliance  = executable('lc-compliance', lc_compliance_sources,