[libcamera-devel,1/2] ipa: Move kMaxFrameContexts to mojom interface
diff mbox series

Message ID 20221212150256.69004-2-umang.jain@ideasonboard.com
State Deferred
Headers show
Series
  • pipeline-handler: Consider in-flight max requests
Related show

Commit Message

Umang Jain Dec. 12, 2022, 3:02 p.m. UTC 
Move kMaxFrameContexts to the mojom interface. This will prepare the
pipeline handler class to manage queuing of requests to the IPA.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 include/libcamera/ipa/ipu3.mojom   | 3 +++
 include/libcamera/ipa/rkisp1.mojom | 3 +++
 src/ipa/ipu3/ipu3.cpp              | 3 ---
 src/ipa/rkisp1/rkisp1.cpp          | 3 ---
 4 files changed, 6 insertions(+), 6 deletions(-)

Patch
diff mbox series 

diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
index d1b1c6b8..b1ecd57f 100644
--- a/include/libcamera/ipa/ipu3.mojom
+++ b/include/libcamera/ipa/ipu3.mojom
@@ -8,6 +8,9 @@  module ipa.ipu3;
 
 import "include/libcamera/ipa/core.mojom";
 
+/* Maximum number of frame contexts to be held */
+const uint32 kMaxFrameContexts = 16;
+
 struct IPAConfigInfo {
 	libcamera.IPACameraSensorInfo sensorInfo;
 	libcamera.ControlInfoMap sensorControls;
diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom
index 1009e970..62c59fbd 100644
--- a/include/libcamera/ipa/rkisp1.mojom
+++ b/include/libcamera/ipa/rkisp1.mojom
@@ -8,6 +8,9 @@  module ipa.rkisp1;
 
 import "include/libcamera/ipa/core.mojom";
 
+/* Maximum number of frame contexts to be held */
+const uint32 kMaxFrameContexts = 16;
+
 struct IPAConfigInfo {
 	libcamera.IPACameraSensorInfo sensorInfo;
 	libcamera.ControlInfoMap sensorControls;
diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index 08ee6eb3..1cfae8fe 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -55,9 +55,6 @@  static constexpr uint32_t kMinCellSizeLog2 = 3;
 /* log2 of the maximum grid cell width and height, in pixels */
 static constexpr uint32_t kMaxCellSizeLog2 = 6;
 
-/* Maximum number of frame contexts to be held */
-static constexpr uint32_t kMaxFrameContexts = 16;
-
 namespace libcamera {
 
 LOG_DEFINE_CATEGORY(IPAIPU3)
diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index 6544c925..509be2d3 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -41,9 +41,6 @@  using namespace std::literals::chrono_literals;
 
 namespace ipa::rkisp1 {
 
-/* Maximum number of frame contexts to be held */
-static constexpr uint32_t kMaxFrameContexts = 16;
-
 class IPARkISP1 : public IPARkISP1Interface, public Module
 {
 public: