| Message ID | 20221205165117.30277-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Commit | 4a7c8a98daedbe69906653727f08732517b42a56 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Jacopo Mondi via libcamera-devel (2022-12-05 16:51:17) > Add whitespace to correct the error message. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/android/camera_hal_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp > index b229e2d5067c..a86e23d443d3 100644 > --- a/src/android/camera_hal_manager.cpp > +++ b/src/android/camera_hal_manager.cpp > @@ -141,7 +141,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr<Camera> cam) > if (!isCameraExternal && !halConfig_.exists()) { > LOG(HAL, Error) > << "HAL configuration file is mandatory for internal cameras." > - << " Camera " << cam->id() << "failed to load"; > + << " Camera " << cam->id() << " failed to load"; > return; > } > > -- > 2.38.1 >
Hi Jacopo, On 12/6/22 12:51 AM, Jacopo Mondi via libcamera-devel wrote: > Add whitespace to correct the error message. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > src/android/camera_hal_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp > index b229e2d5067c..a86e23d443d3 100644 > --- a/src/android/camera_hal_manager.cpp > +++ b/src/android/camera_hal_manager.cpp > @@ -141,7 +141,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr<Camera> cam) > if (!isCameraExternal && !halConfig_.exists()) { > LOG(HAL, Error) > << "HAL configuration file is mandatory for internal cameras." > - << " Camera " << cam->id() << "failed to load"; > + << " Camera " << cam->id() << " failed to load"; > return; > } >
diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp index b229e2d5067c..a86e23d443d3 100644 --- a/src/android/camera_hal_manager.cpp +++ b/src/android/camera_hal_manager.cpp @@ -141,7 +141,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr<Camera> cam) if (!isCameraExternal && !halConfig_.exists()) { LOG(HAL, Error) << "HAL configuration file is mandatory for internal cameras." - << " Camera " << cam->id() << "failed to load"; + << " Camera " << cam->id() << " failed to load"; return; }
Add whitespace to correct the error message. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/android/camera_hal_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)