[libcamera-devel,v7,3/6] Add meson.build in src/android/jpeg
diff mbox series

Message ID 20221201092733.2042078-4-chenghaoyang@google.com
State Accepted
Headers show
Series
  • Add CrOS JEA implementation
Related show

Commit Message

Harvey Yang Dec. 1, 2022, 9:27 a.m. UTC 
From: Harvey Yang <chenghaoyang@chromium.org>

To further control sources in jpeg to build based on the platform, this
patch adds meson.build in src/android/jpeg directory.

Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>
---
 src/android/jpeg/meson.build | 8 ++++++++
 src/android/meson.build      | 5 +----
 2 files changed, 9 insertions(+), 4 deletions(-)
 create mode 100644 src/android/jpeg/meson.build

Comments

Laurent Pinchart Dec. 7, 2022, 3:27 a.m. UTC | #1 
Hi Harvey,

Thank you for the patch.

On Thu, Dec 01, 2022 at 09:27:30AM +0000, Harvey Yang via libcamera-devel wrote:
> From: Harvey Yang <chenghaoyang@chromium.org>
> 
> To further control sources in jpeg to build based on the platform, this
> patch adds meson.build in src/android/jpeg directory.
> 
> Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/jpeg/meson.build | 8 ++++++++
>  src/android/meson.build      | 5 +----
>  2 files changed, 9 insertions(+), 4 deletions(-)
>  create mode 100644 src/android/jpeg/meson.build
> 
> diff --git a/src/android/jpeg/meson.build b/src/android/jpeg/meson.build
> new file mode 100644
> index 00000000..08397a87
> --- /dev/null
> +++ b/src/android/jpeg/meson.build
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: CC0-1.0
> +
> +android_hal_sources += files([
> +    'encoder_libjpeg.cpp',
> +    'exif.cpp',
> +    'post_processor_jpeg.cpp',
> +    'thumbnailer.cpp'
> +])
> diff --git a/src/android/meson.build b/src/android/meson.build
> index c2773f9e..b24e2e52 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -47,16 +47,13 @@ android_hal_sources = files([
>      'camera_ops.cpp',
>      'camera_request.cpp',
>      'camera_stream.cpp',
> -    'jpeg/encoder_libjpeg.cpp',
> -    'jpeg/exif.cpp',
> -    'jpeg/post_processor_jpeg.cpp',
> -    'jpeg/thumbnailer.cpp',
>      'yuv/post_processor_yuv.cpp'
>  ])
>  
>  android_cpp_args = []
>  
>  subdir('cros')
> +subdir('jpeg')
>  subdir('mm')
>  
>  android_camera_metadata_sources = files([

Patch
diff mbox series 

diff --git a/src/android/jpeg/meson.build b/src/android/jpeg/meson.build
new file mode 100644
index 00000000..08397a87
--- /dev/null
+++ b/src/android/jpeg/meson.build
@@ -0,0 +1,8 @@ 
+# SPDX-License-Identifier: CC0-1.0
+
+android_hal_sources += files([
+    'encoder_libjpeg.cpp',
+    'exif.cpp',
+    'post_processor_jpeg.cpp',
+    'thumbnailer.cpp'
+])
diff --git a/src/android/meson.build b/src/android/meson.build
index c2773f9e..b24e2e52 100644
--- a/src/android/meson.build
+++ b/src/android/meson.build
@@ -47,16 +47,13 @@  android_hal_sources = files([
     'camera_ops.cpp',
     'camera_request.cpp',
     'camera_stream.cpp',
-    'jpeg/encoder_libjpeg.cpp',
-    'jpeg/exif.cpp',
-    'jpeg/post_processor_jpeg.cpp',
-    'jpeg/thumbnailer.cpp',
     'yuv/post_processor_yuv.cpp'
 ])
 
 android_cpp_args = []
 
 subdir('cros')
+subdir('jpeg')
 subdir('mm')
 
 android_camera_metadata_sources = files([