| Message ID | 20221122112224.31691-3-naush@raspberrypi.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
HI Naush Thanks for the patch. On Tue, 22 Nov 2022 at 11:22, Naushir Patuck via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: > > Add a default constructor to the RPiController::Histogram class that creates > an empty histogram. Since this is a cumulative histogram, push a value of 0 into > the first (and only) bin to signify this. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks! David > --- > src/ipa/raspberrypi/controller/histogram.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h > index 66a68b087964..6b3e3a9e68e4 100644 > --- a/src/ipa/raspberrypi/controller/histogram.h > +++ b/src/ipa/raspberrypi/controller/histogram.h > @@ -20,6 +20,11 @@ namespace RPiController { > class Histogram > { > public: > + Histogram() > + { > + cumulative_.push_back(0); > + } > + > template<typename T> Histogram(T *histogram, int num) > { > assert(num); > -- > 2.25.1 >
diff --git a/src/ipa/raspberrypi/controller/histogram.h b/src/ipa/raspberrypi/controller/histogram.h index 66a68b087964..6b3e3a9e68e4 100644 --- a/src/ipa/raspberrypi/controller/histogram.h +++ b/src/ipa/raspberrypi/controller/histogram.h @@ -20,6 +20,11 @@ namespace RPiController { class Histogram { public: + Histogram() + { + cumulative_.push_back(0); + } + template<typename T> Histogram(T *histogram, int num) { assert(num);
Add a default constructor to the RPiController::Histogram class that creates an empty histogram. Since this is a cumulative histogram, push a value of 0 into the first (and only) bin to signify this. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/ipa/raspberrypi/controller/histogram.h | 5 +++++ 1 file changed, 5 insertions(+)