[libcamera-devel] libcamera: Update libcamera.h

Message ID 20190108143020.9820-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit afcec99b99c3313805deaededa3158e4ad089b6e
Headers show
Series
  • [libcamera-devel] libcamera: Update libcamera.h
Related show

Commit Message

Laurent Pinchart Jan. 8, 2019, 2:30 p.m. UTC
libcamera.h hasn't been updated with the recently added public headers
event_notifier.h, signal.h and timer.h. Add them.

The event_dispatcher_poll.h header, which used to be public, is now
private, but hasn't been removed from libcamera.h. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/libcamera.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Niklas Söderlund Jan. 9, 2019, 3:38 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2019-01-08 16:30:20 +0200, Laurent Pinchart wrote:
> libcamera.h hasn't been updated with the recently added public headers
> event_notifier.h, signal.h and timer.h. Add them.
> 
> The event_dispatcher_poll.h header, which used to be public, is now
> private, but hasn't been removed from libcamera.h. Remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  include/libcamera/libcamera.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h
> index 2dcaeda49812..c0511cf6d662 100644
> --- a/include/libcamera/libcamera.h
> +++ b/include/libcamera/libcamera.h
> @@ -10,6 +10,8 @@
>  #include <libcamera/camera.h>
>  #include <libcamera/camera_manager.h>
>  #include <libcamera/event_dispatcher.h>
> -#include <libcamera/event_dispatcher_poll.h>
> +#include <libcamera/event_notifier.h>
> +#include <libcamera/signal.h>
> +#include <libcamera/timer.h>
>  
>  #endif /* __LIBCAMERA_LIBCAMERA_H__ */
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h
index 2dcaeda49812..c0511cf6d662 100644
--- a/include/libcamera/libcamera.h
+++ b/include/libcamera/libcamera.h
@@ -10,6 +10,8 @@ 
 #include <libcamera/camera.h>
 #include <libcamera/camera_manager.h>
 #include <libcamera/event_dispatcher.h>
-#include <libcamera/event_dispatcher_poll.h>
+#include <libcamera/event_notifier.h>
+#include <libcamera/signal.h>
+#include <libcamera/timer.h>
 
 #endif /* __LIBCAMERA_LIBCAMERA_H__ */