| Message ID | 20190812124642.24287-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for your work. On 2019-08-12 15:46:25 +0300, Laurent Pinchart wrote: > The message() method shouldn't be called externally (except by a few > friend classes), make it protected. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > include/libcamera/object.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/libcamera/object.h b/include/libcamera/object.h > index 5c251a822d9a..3d08d69a9044 100644 > --- a/include/libcamera/object.h > +++ b/include/libcamera/object.h > @@ -26,11 +26,13 @@ public: > virtual ~Object(); > > void postMessage(std::unique_ptr<Message> msg); > - virtual void message(Message *msg); > > Thread *thread() const { return thread_; } > void moveToThread(Thread *thread); > > +protected: > + virtual void message(Message *msg); > + > private: > template<typename... Args> > friend class Signal; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/include/libcamera/object.h b/include/libcamera/object.h index 5c251a822d9a..3d08d69a9044 100644 --- a/include/libcamera/object.h +++ b/include/libcamera/object.h @@ -26,11 +26,13 @@ public: virtual ~Object(); void postMessage(std::unique_ptr<Message> msg); - virtual void message(Message *msg); Thread *thread() const { return thread_; } void moveToThread(Thread *thread); +protected: + virtual void message(Message *msg); + private: template<typename... Args> friend class Signal;
The message() method shouldn't be called externally (except by a few friend classes), make it protected. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/object.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)