[libcamera-devel,v3,2/5] libcamera: base: thread: Apply clang thread safety annotation
diff mbox series

Message ID 20221103132041.64644-3-umang.jain@ideasonboard.com
State Accepted
Delegated to: Umang Jain
Headers show
Series
  • Apply clang thread safety annotation libcamera-core and v4l2
Related show

Commit Message

Umang Jain Nov. 3, 2022, 1:20 p.m. UTC 
From: Hirokazu Honda <hiroh@chromium.org>

This annotates member variables of ThreadData by clang thread
safety annotations.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/libcamera/base/thread.cpp | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp
index 6bda9d14..b96951ac 100644
--- a/src/libcamera/base/thread.cpp
+++ b/src/libcamera/base/thread.cpp
@@ -151,7 +151,7 @@  private:
 	friend class ThreadMain;
 
 	Thread *thread_;
-	bool running_;
+	bool running_ LIBCAMERA_TSA_GUARDED_BY(mutex_);
 	pid_t tid_;
 
 	Mutex mutex_;
@@ -422,11 +422,15 @@  bool Thread::wait(utils::duration duration)
 	{
 		MutexLocker locker(data_->mutex_);
 
+		auto isRunning = ([&]() LIBCAMERA_TSA_REQUIRES(data_->mutex_) {
+			return !data_->running_;
+		});
+
 		if (duration == utils::duration::max())
-			data_->cv_.wait(locker, [&]() { return !data_->running_; });
+			data_->cv_.wait(locker, isRunning);
 		else
 			hasFinished = data_->cv_.wait_for(locker, duration,
-							  [&]() { return !data_->running_; });
+							  isRunning);
 	}
 
 	if (thread_.joinable())