[libcamera-devel,v4,4/4] tests: camera-sensor: Test using invalid media bus format

Message ID 20190810011333.8731-5-niklas.soderlund@ragnatech.se
State Accepted
Commit c64b898a35134090c165cfc085dd6556fdb2347f
Headers show
Series
  • libcamera: Fix issues with vimc and Linux v5.2
Related show

Commit Message

Niklas Söderlund Aug. 10, 2019, 1:13 a.m. UTC
Linux commit b6c61a6c37317efd ("media: vimc: propagate pixel format in
the stream") changes the sensor in the vimc media graph to accept all
media bus format currently described in Linux. This prevents the
camera-sensor test case to verify that a supported media bus format is
selected from a list of defined formats, fix this by using an invalid
media bus format in the test case.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 test/camera-sensor.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp
index 092cbdd8111ce70d..9fe59cc98d79ccab 100644
--- a/test/camera-sensor.cpp
+++ b/test/camera-sensor.cpp
@@ -83,7 +83,8 @@  protected:
 			return TestFail;
 		}
 
-		V4L2SubdeviceFormat format = sensor_->getFormat({ MEDIA_BUS_FMT_UYVY8_2X8,
+		/* Use an invalid format and make sure it's not selected. */
+		V4L2SubdeviceFormat format = sensor_->getFormat({ 0xdeadbeef,
 								  MEDIA_BUS_FMT_SBGGR10_1X10,
 								  MEDIA_BUS_FMT_BGR888_1X24 },
 								Size(1024, 768));