| Message ID | 20190808151221.24254-6-kieran.bingham@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On Thu, Aug 08, 2019 at 04:12:20PM +0100, Kieran Bingham wrote: > The 'exists()' call is not used within the code base. > Remove it. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp > index b26d06ad4519..b4f4ae672580 100644 > --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp > +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp > @@ -6,7 +6,6 @@ > */ > > #include <iostream> > -#include <sys/stat.h> > > #include "v4l2_videodevice_test.h" > > @@ -16,16 +15,6 @@ > using namespace std; > using namespace libcamera; > > -bool exists(const std::string &path) > -{ > - struct stat sb; > - > - if (stat(path.c_str(), &sb) == 0) > - return true; > - > - return false; > -} > - > int V4L2VideoDeviceTest::init() > { > enumerator_ = DeviceEnumerator::create();
diff --git a/test/v4l2_videodevice/v4l2_videodevice_test.cpp b/test/v4l2_videodevice/v4l2_videodevice_test.cpp index b26d06ad4519..b4f4ae672580 100644 --- a/test/v4l2_videodevice/v4l2_videodevice_test.cpp +++ b/test/v4l2_videodevice/v4l2_videodevice_test.cpp @@ -6,7 +6,6 @@ */ #include <iostream> -#include <sys/stat.h> #include "v4l2_videodevice_test.h" @@ -16,16 +15,6 @@ using namespace std; using namespace libcamera; -bool exists(const std::string &path) -{ - struct stat sb; - - if (stat(path.c_str(), &sb) == 0) - return true; - - return false; -} - int V4L2VideoDeviceTest::init() { enumerator_ = DeviceEnumerator::create();
The 'exists()' call is not used within the code base. Remove it. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- test/v4l2_videodevice/v4l2_videodevice_test.cpp | 11 ----------- 1 file changed, 11 deletions(-)