[libcamera-devel,v3,4/4] ipa: raspberrypi: Fix the imx296 mono tuning black level
diff mbox series

Message ID 20221003095558.1993-5-naush@raspberrypi.com
State Accepted
Headers show
Series
  • imx296 colour tuning
Related show

Commit Message

Naushir Patuck Oct. 3, 2022, 9:55 a.m. UTC 
The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning
file.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Oct. 4, 2022, 7:41 p.m. UTC | #1 
Hi Naush,

Thank you for the patch.

On Mon, Oct 03, 2022 at 10:55:58AM +0100, Naushir Patuck via libcamera-devel wrote:
> The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning
> file.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
> index 490c0fda0cca..b68b11dbd609 100644
> --- a/src/ipa/raspberrypi/data/imx296_mono.json
> +++ b/src/ipa/raspberrypi/data/imx296_mono.json
> @@ -5,7 +5,7 @@
>          {
>              "rpi.black_level":
>              {
> -                "black_level": 4096
> +                "black_level": 3840
>              }
>          },
>          {

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
index 490c0fda0cca..b68b11dbd609 100644
--- a/src/ipa/raspberrypi/data/imx296_mono.json
+++ b/src/ipa/raspberrypi/data/imx296_mono.json
@@ -5,7 +5,7 @@ 
         {
             "rpi.black_level":
             {
-                "black_level": 4096
+                "black_level": 3840
             }
         },
         {