| Message ID | 20220929143626.3100668-4-kieran.bingham@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, On 9/29/22 16:36, Kieran Bingham via libcamera-devel wrote: > Add the SPDX header, and a reference to the upstream source for > this helper script. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > This is kept separate to highlight this is a modification from the original. > > > utils/semver | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/semver b/utils/semver > index 5b25f40ba48c..e9d092d94446 100755 > --- a/utils/semver > +++ b/utils/semver > @@ -1,5 +1,8 @@ > #!/usr/bin/env bash > > +# SPDX-License-Identifier: Apache-2.0 > +# https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_fsaintjacques_semver-2Dtool&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=I4mKHgnyXjtiBROzbl7XiivOC_HQKAaBoHRwFvnqx3EPojV75B5Owge_aP8vlAs2&s=vtYOv14OcLChlhudJ0UnSDY6uzWb52paMYLU0mwODvw&e= > + Maybe worth adding from which commit this was taken? Cheers, Quentin
Hi Kieran might it even be upstreamed ? On Thu, Sep 29, 2022 at 03:36:25PM +0100, Kieran Bingham via libcamera-devel wrote: > Add the SPDX header, and a reference to the upstream source for > this helper script. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > This is kept separate to highlight this is a modification from the original. > > > utils/semver | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/utils/semver b/utils/semver > index 5b25f40ba48c..e9d092d94446 100755 > --- a/utils/semver > +++ b/utils/semver > @@ -1,5 +1,8 @@ > #!/usr/bin/env bash > > +# SPDX-License-Identifier: Apache-2.0 > +# https://github.com/fsaintjacques/semver-tool > + > set -o errexit -o nounset -o pipefail > > NAT='0|[1-9][0-9]*' > -- > 2.34.1 >
Quoting Quentin Schulz via libcamera-devel (2022-09-30 12:43:10)
> Maybe worth adding from which commit this was taken?
Yes, good idea.
https://github.com/fsaintjacques/semver-tool/commit/cac039e8b73bc6fdf2f328437ed40f52abf0d05a
is more precise.
--
Kieran
On Fri, Sep 30, 2022 at 05:43:54PM +0200, Jacopo Mondi via libcamera-devel wrote: > Hi Kieran > might it even be upstreamed ? That's a good idea (at least for the SPDX tag). It's not a blocker to merge this though. > On Thu, Sep 29, 2022 at 03:36:25PM +0100, Kieran Bingham via libcamera-devel wrote: > > Add the SPDX header, and a reference to the upstream source for > > this helper script. > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > > This is kept separate to highlight this is a modification from the original. > > > > > > utils/semver | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/utils/semver b/utils/semver > > index 5b25f40ba48c..e9d092d94446 100755 > > --- a/utils/semver > > +++ b/utils/semver > > @@ -1,5 +1,8 @@ > > #!/usr/bin/env bash > > > > +# SPDX-License-Identifier: Apache-2.0 > > +# https://github.com/fsaintjacques/semver-tool > > + > > set -o errexit -o nounset -o pipefail > > > > NAT='0|[1-9][0-9]*'
On Fri, Sep 30, 2022 at 04:45:54PM +0100, Kieran Bingham via libcamera-devel wrote: > Quoting Quentin Schulz via libcamera-devel (2022-09-30 12:43:10) > > > Maybe worth adding from which commit this was taken? > > Yes, good idea. > > https://github.com/fsaintjacques/semver-tool/commit/cac039e8b73bc6fdf2f328437ed40f52abf0d05a > is more precise. That can also be recorded in the commit message of patch 2/4 instead of modifying the script itself. This way, if upstream accepts the addition of an SPDX tag, we would be able to carry an unmodified version of this script.
diff --git a/utils/semver b/utils/semver index 5b25f40ba48c..e9d092d94446 100755 --- a/utils/semver +++ b/utils/semver @@ -1,5 +1,8 @@ #!/usr/bin/env bash +# SPDX-License-Identifier: Apache-2.0 +# https://github.com/fsaintjacques/semver-tool + set -o errexit -o nounset -o pipefail NAT='0|[1-9][0-9]*'
Add the SPDX header, and a reference to the upstream source for this helper script. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- This is kept separate to highlight this is a modification from the original. utils/semver | 3 +++ 1 file changed, 3 insertions(+)