[libcamera-devel,v2,4/4] ipa: raspberrypi: Fix the imx296 mono tuning black level
diff mbox series

Message ID 20220929072323.7400-5-naush@raspberrypi.com
State Superseded
Headers show
Series
  • imx296 colour tuning
Related show

Commit Message

Naushir Patuck Sept. 29, 2022, 7:23 a.m. UTC 
The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning
file.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Sept. 29, 2022, 7:35 a.m. UTC | #1 
Hi Naush,

On Thu, Sep 29, 2022 at 08:23:23AM +0100, Naushir Patuck via libcamera-devel wrote:
> The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning
> file.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Thanks for clarifying the unit in your previous reply

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
> index 490c0fda0cca..b68b11dbd609 100644
> --- a/src/ipa/raspberrypi/data/imx296_mono.json
> +++ b/src/ipa/raspberrypi/data/imx296_mono.json
> @@ -5,7 +5,7 @@
>          {
>              "rpi.black_level":
>              {
> -                "black_level": 4096
> +                "black_level": 3840
>              }
>          },
>          {
> --
> 2.25.1
>
David Plowman Oct. 3, 2022, 9:43 a.m. UTC | #2 
Hi Naush

Thanks for the patch!

On Thu, 29 Sept 2022 at 08:35, Jacopo Mondi via libcamera-devel
<libcamera-devel@lists.libcamera.org> wrote:
>
> Hi Naush,
>
> On Thu, Sep 29, 2022 at 08:23:23AM +0100, Naushir Patuck via libcamera-devel wrote:
> > The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning
> > file.
> >
> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
>
> Thanks for clarifying the unit in your previous reply
>
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Thanks
David

>
> Thanks
>   j
>
> > ---
> >  src/ipa/raspberrypi/data/imx296_mono.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
> > index 490c0fda0cca..b68b11dbd609 100644
> > --- a/src/ipa/raspberrypi/data/imx296_mono.json
> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json
> > @@ -5,7 +5,7 @@
> >          {
> >              "rpi.black_level":
> >              {
> > -                "black_level": 4096
> > +                "black_level": 3840
> >              }
> >          },
> >          {
> > --
> > 2.25.1
> >

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json
index 490c0fda0cca..b68b11dbd609 100644
--- a/src/ipa/raspberrypi/data/imx296_mono.json
+++ b/src/ipa/raspberrypi/data/imx296_mono.json
@@ -5,7 +5,7 @@ 
         {
             "rpi.black_level":
             {
-                "black_level": 4096
+                "black_level": 3840
             }
         },
         {