[libcamera-devel] libcamera: override "libcamera" dependency in meson

17295 diff mbox series

Overriding the dependency enables libcamera to be used
as a meson subprojet more easily.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
---
 src/libcamera/meson.build | 2 ++
 1 file changed, 2 insertions(+)

--
2.37.3

Hi Barnabás,

Thank you for the patch.

On Sun, Sep 04, 2022 at 06:40:27PM +0000, Barnabás Pőcze via libcamera-devel wrote:
> 
> Overriding the dependency enables libcamera to be used
> as a meson subprojet more easily.

I didn't know about this feature, it's nice.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
> ---
>  src/libcamera/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index ce1f0f2f..63b47b17 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -189,4 +189,6 @@ pkg_mod.generate(libcamera,
>                   description : 'Complex Camera Support Library',
>                   subdirs : 'libcamera')
> 
> +meson.override_dependency('libcamera', libcamera_public)
> +
>  subdir('proxy/worker')

Hi


2022. szeptember 5., hétfő 1:31 keltezéssel, Laurent Pinchart írta:

> Hi Barnabás,
>
> Thank you for the patch.
>
> On Sun, Sep 04, 2022 at 06:40:27PM +0000,
>
> Barnabás Pőcze
>
> via libcamera-devel wrote:
>
> > Overriding the dependency enables libcamera to be used
> > as a meson subprojet more easily.
                      ^^
I just realized this should have been "subproject". Should I send
a new version, or if the patch is accepted, can whoever is applying it
fix the typo?

> [...]


Regards,
Barnabás Pőcze

On Sun, Sep 04, 2022 at 11:45:18PM +0000, Barnabás Pőcze wrote:
> Hi
> 
> 2022. szeptember 5., hétfő 1:31 keltezéssel, Laurent Pinchart írta:
> 
> > Hi Barnabás,
> >
> > Thank you for the patch.
> >
> > On Sun, Sep 04, 2022 at 06:40:27PM +0000,
> >
> > Barnabás Pőcze
> >
> > via libcamera-devel wrote:
> >
> > > Overriding the dependency enables libcamera to be used
> > > as a meson subprojet more easily.
>                       ^^
> I just realized this should have been "subproject". Should I send
> a new version, or if the patch is accepted, can whoever is applying it
> fix the typo?

No need to send a new version, I've fixed this in my tree already.

> > [...]

Hi Barnabás,

On 9/5/22 5:01 AM, Laurent Pinchart via libcamera-devel wrote:
> Hi Barnabás,
>
> Thank you for the patch.
>
> On Sun, Sep 04, 2022 at 06:40:27PM +0000, Barnabás Pőcze via libcamera-devel wrote:
>> Overriding the dependency enables libcamera to be used
>> as a meson subprojet more easily.
> I didn't know about this feature, it's nice.

indeed!
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>
>> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
>> ---
>>   src/libcamera/meson.build | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
>> index ce1f0f2f..63b47b17 100644
>> --- a/src/libcamera/meson.build
>> +++ b/src/libcamera/meson.build
>> @@ -189,4 +189,6 @@ pkg_mod.generate(libcamera,
>>                    description : 'Complex Camera Support Library',
>>                    subdirs : 'libcamera')
>>
>> +meson.override_dependency('libcamera', libcamera_public)
>> +
>>   subdir('proxy/worker')

2022. szeptember 5., hétfő 2:04 keltezéssel, Laurent Pinchart írta:

> [...]
> > > > Overriding the dependency enables libcamera to be used
> > > > as a meson subprojet more easily.
> >                       ^^
> > I just realized this should have been "subproject". Should I send
> > a new version, or if the patch is accepted, can whoever is applying it
> > fix the typo?
> 
> No need to send a new version, I've fixed this in my tree already.

Thanks!


Regards,
Barnabás Pőcze