[libcamera-devel,2/5] meson: options: Add 'android' configuration option

Message ID 20190801155420.24694-3-jacopo@jmondi.org
State Superseded
Headers show
Series
  • android: Add initial Camera HAL implementation
Related show

Commit Message

Jacopo Mondi Aug. 1, 2019, 3:54 p.m. UTC
Add an 'android' configuration option, set to false by default, which
enables the compilation of the Android HAL adaption layer on top of
libcamera.

To enable compiling the Camera HAL wrapper in:
$ meson configure -Dandroid=true

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 meson_options.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Laurent Pinchart Aug. 5, 2019, 11:41 a.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Thu, Aug 01, 2019 at 05:54:17PM +0200, Jacopo Mondi wrote:
> Add an 'android' configuration option, set to false by default, which
> enables the compilation of the Android HAL adaption layer on top of
> libcamera.
> 
> To enable compiling the Camera HAL wrapper in:
> $ meson configure -Dandroid=true
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  meson_options.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index 97efc85b4412..5fa8176b8e8b 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -1,3 +1,8 @@
> +option('android',
> +        type : 'boolean',
> +	value : false,
> +        description : 'Compile libcamera with Android Camera3 HAL interface')

Mixing tabs and space. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

(I would have squashed this with 5/5, but I don't mind much if you want
to keep it separate)

> +
>  option('documentation',
>          type : 'boolean',
>          description : 'Generate the project documentation')

Patch

diff --git a/meson_options.txt b/meson_options.txt
index 97efc85b4412..5fa8176b8e8b 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,3 +1,8 @@ 
+option('android',
+        type : 'boolean',
+	value : false,
+        description : 'Compile libcamera with Android Camera3 HAL interface')
+
 option('documentation',
         type : 'boolean',
         description : 'Generate the project documentation')