[libcamera-devel] libcamera: pipeline: ipu3: Fix argument name mismatch

Message ID 20190717071128.6192-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 9e6147d30392178abffd7c71426dc70250127ce2
Headers show
Series
  • [libcamera-devel] libcamera: pipeline: ipu3: Fix argument name mismatch
Related show

Commit Message

Laurent Pinchart July 17, 2019, 7:11 a.m. UTC
Fix an argument name mismatch between method declaration and
definition.

Reported-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham July 19, 2019, 11:43 a.m. UTC | #1
On 17/07/2019 08:11, Laurent Pinchart wrote:
> Fix an argument name mismatch between method declaration and
> definition.
> 
> Reported-by: Paul Elder <paul.elder@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index c27fe75577f5..827906d5cd2e 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -122,7 +122,7 @@ public:
>  	BufferPool *exportBuffers();
>  	void freeBuffers();
>  
> -	int start(std::vector<std::unique_ptr<Buffer>> *buffer);
> +	int start(std::vector<std::unique_ptr<Buffer>> *buffers);
>  	int stop();
>  
>  	static int mediaBusToFormat(unsigned int code);
>
Niklas Söderlund July 20, 2019, 1:08 p.m. UTC | #2
Hi Laurent,

Thanks for your work.

On 2019-07-17 10:11:28 +0300, Laurent Pinchart wrote:
> Fix an argument name mismatch between method declaration and
> definition.
> 
> Reported-by: Paul Elder <paul.elder@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index c27fe75577f5..827906d5cd2e 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -122,7 +122,7 @@ public:
>  	BufferPool *exportBuffers();
>  	void freeBuffers();
>  
> -	int start(std::vector<std::unique_ptr<Buffer>> *buffer);
> +	int start(std::vector<std::unique_ptr<Buffer>> *buffers);
>  	int stop();
>  
>  	static int mediaBusToFormat(unsigned int code);
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index c27fe75577f5..827906d5cd2e 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -122,7 +122,7 @@  public:
 	BufferPool *exportBuffers();
 	void freeBuffers();
 
-	int start(std::vector<std::unique_ptr<Buffer>> *buffer);
+	int start(std::vector<std::unique_ptr<Buffer>> *buffers);
 	int stop();
 
 	static int mediaBusToFormat(unsigned int code);