[libcamera-devel,3/3] libcamera: pipeline: remove unused assignment
diff mbox series

Message ID 20220814095241.137108-3-Rauch.Christian@gmx.de
State Superseded
Headers show
Series
  • [libcamera-devel,1/3] libcamera: remove unused header
Related show

Commit Message

Christian Rauch Aug. 14, 2022, 9:52 a.m. UTC 
Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
 1 file changed, 1 deletion(-)

--
2.34.1

Comments

Laurent Pinchart Aug. 16, 2022, 3:50 a.m. UTC | #1 
Hi Christian,

Thank you for the patch.

On Sun, Aug 14, 2022 at 11:52:41AM +0200, Christian Rauch via libcamera-devel wrote:

With a commit message,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 93287332..03bbe6b4 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
>  		/* \todo Turn this into a hard failure. */
>  		LOG(RkISP1, Warning) << "Camera sensor information not available";
>  		sensorInfo = {};
> -		ret = 0;
>  	}
> 
>  	std::map<uint32_t, ControlInfoMap> entityControls;
Christian Rauch Aug. 16, 2022, 6:42 p.m. UTC | #2 
Hi Laurent,

I added short commit messages to those commits in v2. I was hoping that
those trivial changes do not need a dedicated message body :-)

Best,
Christian


Am 16.08.22 um 05:50 schrieb Laurent Pinchart:
> Hi Christian,
>
> Thank you for the patch.
>
> On Sun, Aug 14, 2022 at 11:52:41AM +0200, Christian Rauch via libcamera-devel wrote:
>
> With a commit message,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
>> ---
>>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> index 93287332..03bbe6b4 100644
>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
>>  		/* \todo Turn this into a hard failure. */
>>  		LOG(RkISP1, Warning) << "Camera sensor information not available";
>>  		sensorInfo = {};
>> -		ret = 0;
>>  	}
>>
>>  	std::map<uint32_t, ControlInfoMap> entityControls;
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 93287332..03bbe6b4 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -688,7 +688,6 @@  int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
 		/* \todo Turn this into a hard failure. */
 		LOG(RkISP1, Warning) << "Camera sensor information not available";
 		sensorInfo = {};
-		ret = 0;
 	}

 	std::map<uint32_t, ControlInfoMap> entityControls;