[libcamera-devel,v2,6/6] controls: Remove AeEnable and AeLocked
diff mbox series

Message ID 20220811150219.62066-7-jacopo@jmondi.org
State New
Headers show
Series
  • AEGC controls
Related show

Commit Message

Jacopo Mondi Aug. 11, 2022, 3:02 p.m. UTC
Now that the codebase has been ported to use the new AEGC controls
remove the definition of AeEnable and AeLocked.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/control_ids.yaml | 18 ------------------
 1 file changed, 18 deletions(-)

Comments

Nicolas Dufresne via libcamera-devel Aug. 16, 2022, 5:32 a.m. UTC | #1
On Thu, Aug 11, 2022 at 05:02:19PM +0200, Jacopo Mondi via libcamera-devel wrote:
> Now that the codebase has been ported to use the new AEGC controls
> remove the definition of AeEnable and AeLocked.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/control_ids.yaml | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 694659af4b7d..f7f8b2e525d8 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -7,24 +7,6 @@
>  # Unless otherwise stated, all controls are bi-directional, i.e. they can be
>  # set through Request::controls() and returned out through Request::metadata().
>  controls:
> -  - AeEnable:
> -      type: bool
> -      description: |
> -        Enable or disable the AE.
> -
> -        \sa ExposureTime AnalogueGain
> -
> -  - AeLocked:
> -      type: bool
> -      description: |
> -        Report the lock status of a running AE algorithm.
> -
> -        If the AE algorithm is locked the value shall be set to true, if it's
> -        converging it shall be set to false. If the AE algorithm is not
> -        running the control shall not be present in the metadata control list.
> -
> -        \sa AeEnable
> -
>    - AeState:
>        type: int32_t
>        description: |
> -- 
> 2.37.1
>

Patch
diff mbox series

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 694659af4b7d..f7f8b2e525d8 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -7,24 +7,6 @@ 
 # Unless otherwise stated, all controls are bi-directional, i.e. they can be
 # set through Request::controls() and returned out through Request::metadata().
 controls:
-  - AeEnable:
-      type: bool
-      description: |
-        Enable or disable the AE.
-
-        \sa ExposureTime AnalogueGain
-
-  - AeLocked:
-      type: bool
-      description: |
-        Report the lock status of a running AE algorithm.
-
-        If the AE algorithm is locked the value shall be set to true, if it's
-        converging it shall be set to false. If the AE algorithm is not
-        running the control shall not be present in the metadata control list.
-
-        \sa AeEnable
-
   - AeState:
       type: int32_t
       description: |