| Message ID | 20220809130806.46753-1-dse@thaumatec.com |
|---|---|
| State | Accepted |
| Commit | 768f1138e9111975959057a621a99518ab78981f |
| Headers | show |
| Series |
|
| Related | show |
Quoting Daniel Semkowicz via libcamera-devel (2022-08-09 14:08:06) > Algorithms are now created dynamically basing on tuning file, so there > is no longer dependency on specific algorithms. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Daniel Semkowicz <dse@thaumatec.com> > --- > src/ipa/rkisp1/rkisp1.cpp | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index 6cf4d169..17d42d38 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -27,10 +27,7 @@ > #include "libcamera/internal/mapped_framebuffer.h" > #include "libcamera/internal/yaml_parser.h" > > -#include "algorithms/agc.h" > #include "algorithms/algorithm.h" > -#include "algorithms/awb.h" > -#include "algorithms/blc.h" > #include "libipa/camera_sensor_helper.h" > > #include "ipa_context.h" > -- > 2.34.1 >
Hi Daniel, Thank you for the patch. On Tue, Aug 09, 2022 at 03:08:06PM +0200, Daniel Semkowicz via libcamera-devel wrote: > Algorithms are now created dynamically basing on tuning file, so there > is no longer dependency on specific algorithms. Good catch. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Daniel Semkowicz <dse@thaumatec.com> > --- > src/ipa/rkisp1/rkisp1.cpp | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index 6cf4d169..17d42d38 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -27,10 +27,7 @@ > #include "libcamera/internal/mapped_framebuffer.h" > #include "libcamera/internal/yaml_parser.h" > > -#include "algorithms/agc.h" > #include "algorithms/algorithm.h" > -#include "algorithms/awb.h" > -#include "algorithms/blc.h" > #include "libipa/camera_sensor_helper.h" > > #include "ipa_context.h"
diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 6cf4d169..17d42d38 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -27,10 +27,7 @@ #include "libcamera/internal/mapped_framebuffer.h" #include "libcamera/internal/yaml_parser.h" -#include "algorithms/agc.h" #include "algorithms/algorithm.h" -#include "algorithms/awb.h" -#include "algorithms/blc.h" #include "libipa/camera_sensor_helper.h" #include "ipa_context.h"
Algorithms are now created dynamically basing on tuning file, so there is no longer dependency on specific algorithms. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com> --- src/ipa/rkisp1/rkisp1.cpp | 3 --- 1 file changed, 3 deletions(-)