[libcamera-devel,v2,1/4] libcamera: meson: Use dependency() to find gnutls
diff mbox series

Message ID 20220808230833.16275-2-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: Support openssl as an alternative to gnutls
Related show

Commit Message

Laurent Pinchart Aug. 8, 2022, 11:08 p.m. UTC 
The gnutls library ships a pkgconfig .pc file. Use the standard
dependency() method to locate it, instead of cc.find_library().

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Curtin Aug. 9, 2022, 10:42 a.m. UTC | #1 
On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> The gnutls library ships a pkgconfig .pc file. Use the standard
> dependency() method to locate it, instead of cc.find_library().
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

LGTM.

Reviewed-by: Eric Curtin <ecurtin@redhat.com>

> ---
>  src/libcamera/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index b57bee7ef6ca..7cc06de4aedc 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -65,7 +65,7 @@ subdir('pipeline')
>  subdir('proxy')
>
>  libdl = cc.find_library('dl')
> -libgnutls = cc.find_library('gnutls', required : true)
> +libgnutls = dependency('gnutls', required : true)
>  libudev = dependency('libudev', required : false)
>  libyaml = dependency('yaml-0.1', required : false)
>
> --
> Regards,
>
> Laurent Pinchart
>
Kieran Bingham Aug. 9, 2022, 12:19 p.m. UTC | #2 
Quoting Laurent Pinchart via libcamera-devel (2022-08-09 00:08:30)
> The gnutls library ships a pkgconfig .pc file. Use the standard
> dependency() method to locate it, instead of cc.find_library().
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Seems reasonable

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index b57bee7ef6ca..7cc06de4aedc 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -65,7 +65,7 @@ subdir('pipeline')
>  subdir('proxy')
>  
>  libdl = cc.find_library('dl')
> -libgnutls = cc.find_library('gnutls', required : true)
> +libgnutls = dependency('gnutls', required : true)
>  libudev = dependency('libudev', required : false)
>  libyaml = dependency('yaml-0.1', required : false)
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index b57bee7ef6ca..7cc06de4aedc 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -65,7 +65,7 @@  subdir('pipeline')
 subdir('proxy')
 
 libdl = cc.find_library('dl')
-libgnutls = cc.find_library('gnutls', required : true)
+libgnutls = dependency('gnutls', required : true)
 libudev = dependency('libudev', required : false)
 libyaml = dependency('yaml-0.1', required : false)