[libcamera-devel,5/9] libcamera: ipa_interface: Include flags.h
diff mbox series

Message ID 20220803112150.3040287-6-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • utils: ipc: Add support for enums and Flags
Related show

Commit Message

Paul Elder Aug. 3, 2022, 11:21 a.m. UTC
Since we will soon be adding support for Flags in IPA interfaces, the
header for Flags needs to be included in ipa_interface.h. Do so.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 include/libcamera/ipa/ipa_interface.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Aug. 9, 2022, 1:45 a.m. UTC | #1
Hi Paul,

Thank you for the patch.

On Wed, Aug 03, 2022 at 08:21:46PM +0900, Paul Elder via libcamera-devel wrote:
> Since we will soon be adding support for Flags in IPA interfaces, the
> header for Flags needs to be included in ipa_interface.h. Do so.

While I'm all for the "one change, one patch" philosophy, we're reaching
the limits of what's reasonable :-) Please squash this with the patch
that uses it.

> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  include/libcamera/ipa/ipa_interface.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
> index 50ca0e7b..8afcfe21 100644
> --- a/include/libcamera/ipa/ipa_interface.h
> +++ b/include/libcamera/ipa/ipa_interface.h
> @@ -13,6 +13,7 @@
>  #include <map>
>  #include <vector>
>  
> +#include <libcamera/base/flags.h>
>  #include <libcamera/base/signal.h>
>  
>  #include <libcamera/controls.h>

Patch
diff mbox series

diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
index 50ca0e7b..8afcfe21 100644
--- a/include/libcamera/ipa/ipa_interface.h
+++ b/include/libcamera/ipa/ipa_interface.h
@@ -13,6 +13,7 @@ 
 #include <map>
 #include <vector>
 
+#include <libcamera/base/flags.h>
 #include <libcamera/base/signal.h>
 
 #include <libcamera/controls.h>