[libcamera-devel,RFC,2/4] ipa: ipu3: Add an uncalibrated.yaml tuning data file
diff mbox series

Message ID 20220802100955.1546-3-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Add tuning data file support to the IPU3 IPA module
Related show

Commit Message

Laurent Pinchart Aug. 2, 2022, 10:09 a.m. UTC
Add a tuning data file for uncalibrated sensors, picked by the pipeline
handler when no sensor-specific tuning file is available. The file lists
the 5 algorithms currently instantiated by the IPA module.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/ipu3/data/meson.build       |  8 ++++++++
 src/ipa/ipu3/data/uncalibrated.yaml | 11 +++++++++++
 src/ipa/ipu3/meson.build            |  1 +
 3 files changed, 20 insertions(+)
 create mode 100644 src/ipa/ipu3/data/meson.build
 create mode 100644 src/ipa/ipu3/data/uncalibrated.yaml

Comments

Kieran Bingham Aug. 8, 2022, 10:57 p.m. UTC | #1
Quoting Laurent Pinchart via libcamera-devel (2022-08-02 11:09:53)
> Add a tuning data file for uncalibrated sensors, picked by the pipeline
> handler when no sensor-specific tuning file is available. The file lists
> the 5 algorithms currently instantiated by the IPA module.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/ipa/ipu3/data/meson.build       |  8 ++++++++
>  src/ipa/ipu3/data/uncalibrated.yaml | 11 +++++++++++
>  src/ipa/ipu3/meson.build            |  1 +
>  3 files changed, 20 insertions(+)
>  create mode 100644 src/ipa/ipu3/data/meson.build
>  create mode 100644 src/ipa/ipu3/data/uncalibrated.yaml
> 
> diff --git a/src/ipa/ipu3/data/meson.build b/src/ipa/ipu3/data/meson.build
> new file mode 100644
> index 000000000000..1f50b6301f77
> --- /dev/null
> +++ b/src/ipa/ipu3/data/meson.build
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: CC0-1.0
> +
> +conf_files = files([
> +    'uncalibrated.yaml',
> +])
> +
> +install_data(conf_files,
> +             install_dir : ipa_data_dir / 'ipu3')
> diff --git a/src/ipa/ipu3/data/uncalibrated.yaml b/src/ipa/ipu3/data/uncalibrated.yaml
> new file mode 100644
> index 000000000000..d98f4445d0a9
> --- /dev/null
> +++ b/src/ipa/ipu3/data/uncalibrated.yaml
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: CC0-1.0
> +%YAML 1.2

With this at 1.1

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> +---
> +version: 1
> +algorithms:
> +  - Af:
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +  - ToneMapping:
> +...
> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build
> index 3194111a5bad..658e7c9bc366 100644
> --- a/src/ipa/ipu3/meson.build
> +++ b/src/ipa/ipu3/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: CC0-1.0
>  
>  subdir('algorithms')
> +subdir('data')
>  
>  ipa_name = 'ipa_ipu3'
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series

diff --git a/src/ipa/ipu3/data/meson.build b/src/ipa/ipu3/data/meson.build
new file mode 100644
index 000000000000..1f50b6301f77
--- /dev/null
+++ b/src/ipa/ipu3/data/meson.build
@@ -0,0 +1,8 @@ 
+# SPDX-License-Identifier: CC0-1.0
+
+conf_files = files([
+    'uncalibrated.yaml',
+])
+
+install_data(conf_files,
+             install_dir : ipa_data_dir / 'ipu3')
diff --git a/src/ipa/ipu3/data/uncalibrated.yaml b/src/ipa/ipu3/data/uncalibrated.yaml
new file mode 100644
index 000000000000..d98f4445d0a9
--- /dev/null
+++ b/src/ipa/ipu3/data/uncalibrated.yaml
@@ -0,0 +1,11 @@ 
+# SPDX-License-Identifier: CC0-1.0
+%YAML 1.2
+---
+version: 1
+algorithms:
+  - Af:
+  - Agc:
+  - Awb:
+  - BlackLevelCorrection:
+  - ToneMapping:
+...
diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build
index 3194111a5bad..658e7c9bc366 100644
--- a/src/ipa/ipu3/meson.build
+++ b/src/ipa/ipu3/meson.build
@@ -1,6 +1,7 @@ 
 # SPDX-License-Identifier: CC0-1.0
 
 subdir('algorithms')
+subdir('data')
 
 ipa_name = 'ipa_ipu3'