| Message ID | 20190712123350.26354-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 1a7f1610e9f823011de4393af8ec9c10aa6b2097 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for the patch. On Fri, Jul 12, 2019 at 03:33:50PM +0300, Laurent Pinchart wrote: > Speed up the test by lowering the resolution to the smallest vivid > supports, 320x180. It looks and runs fine, but I didn't get any speedup. Anyway, it looks like a step in the right direction. Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/v4l2_videodevice/buffer_sharing.cpp | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp > index ede6ec7984a9..7b6a28fffb77 100644 > --- a/test/v4l2_videodevice/buffer_sharing.cpp > +++ b/test/v4l2_videodevice/buffer_sharing.cpp > @@ -58,6 +58,15 @@ protected: > return TestFail; > } > > + format.size.width = 320; > + format.size.height = 180; > + > + ret = capture_->setFormat(&format); > + if (ret) { > + std::cout << "Failed to set capture format" << std::endl; > + return TestFail; > + } > + > ret = output_->setFormat(&format); > if (ret) { > std::cout << "Failed to set output format" << std::endl; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Paul, On Sat, Jul 13, 2019 at 05:26:08AM +0900, Paul Elder wrote: > On Fri, Jul 12, 2019 at 03:33:50PM +0300, Laurent Pinchart wrote: > > Speed up the test by lowering the resolution to the smallest vivid > > supports, 320x180. > > It looks and runs fine, but I didn't get any speedup. That's because you also need to set the frame rate :-) We'll have to add that to libcamera, but in the meantime it can be set externally through yavta or v4l2-ctl. I'll mention that in the commit message. > Anyway, it looks like a step in the right direction. > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > test/v4l2_videodevice/buffer_sharing.cpp | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp > > index ede6ec7984a9..7b6a28fffb77 100644 > > --- a/test/v4l2_videodevice/buffer_sharing.cpp > > +++ b/test/v4l2_videodevice/buffer_sharing.cpp > > @@ -58,6 +58,15 @@ protected: > > return TestFail; > > } > > > > + format.size.width = 320; > > + format.size.height = 180; > > + > > + ret = capture_->setFormat(&format); > > + if (ret) { > > + std::cout << "Failed to set capture format" << std::endl; > > + return TestFail; > > + } > > + > > ret = output_->setFormat(&format); > > if (ret) { > > std::cout << "Failed to set output format" << std::endl;
diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index ede6ec7984a9..7b6a28fffb77 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -58,6 +58,15 @@ protected: return TestFail; } + format.size.width = 320; + format.size.height = 180; + + ret = capture_->setFormat(&format); + if (ret) { + std::cout << "Failed to set capture format" << std::endl; + return TestFail; + } + ret = output_->setFormat(&format); if (ret) { std::cout << "Failed to set output format" << std::endl;
Speed up the test by lowering the resolution to the smallest vivid supports, 320x180. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- test/v4l2_videodevice/buffer_sharing.cpp | 9 +++++++++ 1 file changed, 9 insertions(+)