[libcamera-devel,v2,07/11] ipa: rkisp1: Add OV5675 tuning file
diff mbox series

Message ID 20220713084317.24268-8-dse@thaumatec.com
State Superseded
Headers show
Series
  • ipa: rkisp1: Add autofocus algorithm
Related show

Commit Message

Daniel Semkowicz July 13, 2022, 8:43 a.m. UTC 
Add the OV5675 tuning file with default values and enabled AF algorithm.

Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
---
 src/ipa/rkisp1/data/meson.build |  1 +
 src/ipa/rkisp1/data/ov5675.yaml | 12 ++++++++++++
 2 files changed, 13 insertions(+)
 create mode 100644 src/ipa/rkisp1/data/ov5675.yaml

Comments

Jacopo Mondi July 14, 2022, 6:48 p.m. UTC | #1 
Hi Daniel,

On Wed, Jul 13, 2022 at 10:43:13AM +0200, Daniel Semkowicz via libcamera-devel wrote:
> Add the OV5675 tuning file with default values and enabled AF algorithm.

Have you checked in the datasheet ? Otherwise it's fine to have
place-holders for the time being, but let's record it in a \todo note.

>
> Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
> ---
>  src/ipa/rkisp1/data/meson.build |  1 +
>  src/ipa/rkisp1/data/ov5675.yaml | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
>
> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> index c3b4e388..03d71cbf 100644
> --- a/src/ipa/rkisp1/data/meson.build
> +++ b/src/ipa/rkisp1/data/meson.build
> @@ -3,6 +3,7 @@
>  conf_files = files([
>      'imx219.yaml',
>      'ov5640.yaml',
> +    'ov5675.yaml',
>      'uncalibrated.yaml',
>  ])
>
> diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
> new file mode 100644
> index 00000000..82b2caaf
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/ov5675.yaml
> @@ -0,0 +1,12 @@
> +---
> +version: 1
> +algorithms:
> +  - Af:
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +      R:  256
> +      Gr: 256
> +      Gb: 256
> +      B:  256
> +...
> --
> 2.34.1
>
Daniel Semkowicz July 18, 2022, 3:50 p.m. UTC | #2 
Hi Jacopo,

On Thu, Jul 14, 2022 at 8:48 PM Jacopo Mondi <jacopo@jmondi.org> wrote:
>
> Hi Daniel,
>
> On Wed, Jul 13, 2022 at 10:43:13AM +0200, Daniel Semkowicz via libcamera-devel wrote:
> > Add the OV5675 tuning file with default values and enabled AF algorithm.
>
> Have you checked in the datasheet ? Otherwise it's fine to have
> place-holders for the time being, but let's record it in a \todo note.

No, I just used the default values. These are used even if no parameters
are supplied in the tuning file, so maybe I should remove them from the
file, as it can be misleading that these are the measured values.

Best regards
Daniel

>
> >
> > Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
> > ---
> >  src/ipa/rkisp1/data/meson.build |  1 +
> >  src/ipa/rkisp1/data/ov5675.yaml | 12 ++++++++++++
> >  2 files changed, 13 insertions(+)
> >  create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
> >
> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> > index c3b4e388..03d71cbf 100644
> > --- a/src/ipa/rkisp1/data/meson.build
> > +++ b/src/ipa/rkisp1/data/meson.build
> > @@ -3,6 +3,7 @@
> >  conf_files = files([
> >      'imx219.yaml',
> >      'ov5640.yaml',
> > +    'ov5675.yaml',
> >      'uncalibrated.yaml',
> >  ])
> >
> > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
> > new file mode 100644
> > index 00000000..82b2caaf
> > --- /dev/null
> > +++ b/src/ipa/rkisp1/data/ov5675.yaml
> > @@ -0,0 +1,12 @@
> > +---
> > +version: 1
> > +algorithms:
> > +  - Af:
> > +  - Agc:
> > +  - Awb:
> > +  - BlackLevelCorrection:
> > +      R:  256
> > +      Gr: 256
> > +      Gb: 256
> > +      B:  256
> > +...
> > --
> > 2.34.1
> >

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
index c3b4e388..03d71cbf 100644
--- a/src/ipa/rkisp1/data/meson.build
+++ b/src/ipa/rkisp1/data/meson.build
@@ -3,6 +3,7 @@ 
 conf_files = files([
     'imx219.yaml',
     'ov5640.yaml',
+    'ov5675.yaml',
     'uncalibrated.yaml',
 ])
 
diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
new file mode 100644
index 00000000..82b2caaf
--- /dev/null
+++ b/src/ipa/rkisp1/data/ov5675.yaml
@@ -0,0 +1,12 @@ 
+---
+version: 1
+algorithms:
+  - Af:
+  - Agc:
+  - Awb:
+  - BlackLevelCorrection:
+      R:  256
+      Gr: 256
+      Gb: 256
+      B:  256
+...