[libcamera-devel,v3,04/17] py: cam.py: Remove todo comment
diff mbox series

Message ID 20220701084521.31831-5-tomi.valkeinen@ideasonboard.com
State Accepted
Headers show
Series
  • Python bindings event handling
Related show

Commit Message

Tomi Valkeinen July 1, 2022, 8:45 a.m. UTC
The comment is no longer valid.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
 src/py/cam/cam.py | 3 ---
 1 file changed, 3 deletions(-)

Comments

Jacopo Mondi Aug. 18, 2022, 1:50 p.m. UTC | #1
Hi Tomi

On Fri, Jul 01, 2022 at 11:45:08AM +0300, Tomi Valkeinen wrote:
> The comment is no longer valid.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/py/cam/cam.py | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py
> index 8a82e092..2701d937 100755
> --- a/src/py/cam/cam.py
> +++ b/src/py/cam/cam.py
> @@ -3,9 +3,6 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>
> -# \todo Convert ctx and state dicts to proper classes, and move relevant
> -#       functions to those classes.
> -
>  from typing import Any
>  import argparse
>  import binascii
> --
> 2.34.1
>
Laurent Pinchart Aug. 18, 2022, 3:06 p.m. UTC | #2
Hi Tomi,

Thank you for the patch.

On Fri, Jul 01, 2022 at 11:45:08AM +0300, Tomi Valkeinen wrote:
> The comment is no longer valid.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/py/cam/cam.py | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py
> index 8a82e092..2701d937 100755
> --- a/src/py/cam/cam.py
> +++ b/src/py/cam/cam.py
> @@ -3,9 +3,6 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>  
> -# \todo Convert ctx and state dicts to proper classes, and move relevant
> -#       functions to those classes.
> -
>  from typing import Any
>  import argparse
>  import binascii

Patch
diff mbox series

diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py
index 8a82e092..2701d937 100755
--- a/src/py/cam/cam.py
+++ b/src/py/cam/cam.py
@@ -3,9 +3,6 @@ 
 # SPDX-License-Identifier: GPL-2.0-or-later
 # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
 
-# \todo Convert ctx and state dicts to proper classes, and move relevant
-#       functions to those classes.
-
 from typing import Any
 import argparse
 import binascii