| Message ID | 20220624073528.26670-2-naush@raspberrypi.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush Thanks for the patch! On Fri, 24 Jun 2022 at 08:35, Naushir Patuck via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: > > Add a SensorTemperature control to return the temperature of the camera sensor > in Celsius. This control will only be present in the Request metadata if a > thermal sensor is available to the camera sensor. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/control_ids.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml > index cd1d4512bf2e..ecab3ae97260 100644 > --- a/src/libcamera/control_ids.yaml > +++ b/src/libcamera/control_ids.yaml > @@ -367,6 +367,16 @@ controls: > > size: [2] > > + - SensorTemperature: > + type: float > + description: | > + Temperature measure from the camera sensor in Celsius. This is typically > + obtained by a thermal sensor present on-die or in the camera module. The > + range of reported temperatures is device dependent. > + > + The SensorTemperature control will only be returned in metadata if a > + themal sensor is present. > + Looks good to me. I suppose we could define a device independent range starting at absolute zero, but it's probably not worth the trouble! Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks David > - SensorTimestamp: > type: int64_t > description: | > -- > 2.25.1 >
diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index cd1d4512bf2e..ecab3ae97260 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -367,6 +367,16 @@ controls: size: [2] + - SensorTemperature: + type: float + description: | + Temperature measure from the camera sensor in Celsius. This is typically + obtained by a thermal sensor present on-die or in the camera module. The + range of reported temperatures is device dependent. + + The SensorTemperature control will only be returned in metadata if a + themal sensor is present. + - SensorTimestamp: type: int64_t description: |