[libcamera-devel,v4.1,06/12] ipa: libipa: module: Make the Module class Loggable
diff mbox series

Message ID 20220623232741.19753-1-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Untitled series #3215
Related show

Commit Message

Laurent Pinchart June 23, 2022, 11:27 p.m. UTC
To help attribute messages logged by the Module class to a particular
IPA module, make the class loggable. The logPrefix() function must be
implemented by the IPA module-specific derived class.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v4:

- Fix the commit message
---
 src/ipa/libipa/module.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicolas Dufresne via libcamera-devel June 24, 2022, 7:32 a.m. UTC | #1
Hi Laurent,

On Fri, Jun 24, 2022 at 02:27:41AM +0300, Laurent Pinchart wrote:
> To help attribute messages logged by the Module class to a particular
> IPA module, make the class loggable. The logPrefix() function must be
> implemented by the IPA module-specific derived class.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
> Changes since v4:
> 
> - Fix the commit message
> ---
>  src/ipa/libipa/module.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h
> index 00d5785e1aa0..cd67912f1b0c 100644
> --- a/src/ipa/libipa/module.h
> +++ b/src/ipa/libipa/module.h
> @@ -27,7 +27,7 @@ namespace ipa {
>  
>  template<typename _Context, typename _FrameContext, typename _Config,
>  	 typename _Params, typename _Stats>
> -class Module
> +class Module : public Loggable
>  {
>  public:
>  	using Context = _Context;

Patch
diff mbox series

diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h
index 00d5785e1aa0..cd67912f1b0c 100644
--- a/src/ipa/libipa/module.h
+++ b/src/ipa/libipa/module.h
@@ -27,7 +27,7 @@  namespace ipa {
 
 template<typename _Context, typename _FrameContext, typename _Config,
 	 typename _Params, typename _Stats>
-class Module
+class Module : public Loggable
 {
 public:
 	using Context = _Context;