[libcamera-devel,1/3] libcamera: controls: Add SensorTemperature control
diff mbox series

Message ID 20220623144410.20725-2-naush@raspberrypi.com
State Superseded
Headers show
Series
  • Add SensorTemperature control
Related show

Commit Message

Naushir Patuck June 23, 2022, 2:44 p.m. UTC
Add a SensorTemperature control to return the temperature of the camera sensor
in Celsius. This control will only be present in the Request metadata if a
thermal sensor is available to the camera sensor.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/control_ids.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Kieran Bingham June 23, 2022, 4:15 p.m. UTC | #1
Quoting Naushir Patuck via libcamera-devel (2022-06-23 15:44:08)
> Add a SensorTemperature control to return the temperature of the camera sensor
> in Celsius. This control will only be present in the Request metadata if a
> thermal sensor is available to the camera sensor.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/libcamera/control_ids.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index cd1d4512bf2e..ecab3ae97260 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -367,6 +367,16 @@ controls:
>  
>        size: [2]
>  
> +  - SensorTemperature:
> +      type: float
> +      description: |
> +        Temperature measure from the camera sensor in Celsius. This is typically
> +        obtained by a thermal sensor present on-die or in the camera module. The
> +        range of reported temperatures is device dependent.
> +
> +        The SensorTemperature control will only be returned in metadata if a
> +        themal sensor is present.

Hrm - I don't know if we 'need' to say this last bit, but it seems
correct.  Presumably there are other metadata fields that are optional
to provide and are only in the metadata if they are available.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> +
>    - SensorTimestamp:
>        type: int64_t
>        description: |
> -- 
> 2.25.1
>

Patch
diff mbox series

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index cd1d4512bf2e..ecab3ae97260 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -367,6 +367,16 @@  controls:
 
       size: [2]
 
+  - SensorTemperature:
+      type: float
+      description: |
+        Temperature measure from the camera sensor in Celsius. This is typically
+        obtained by a thermal sensor present on-die or in the camera module. The
+        range of reported temperatures is device dependent.
+
+        The SensorTemperature control will only be returned in metadata if a
+        themal sensor is present.
+
   - SensorTimestamp:
       type: int64_t
       description: |