[libcamera-devel,3/4] utils: rkisp1: Fix pixel format for raw capture
diff mbox series

Message ID 20220620210658.20288-4-laurent.pinchart@ideasonboard.com
State Accepted
Commit 4d3a118c11f5dc3a1eaa2e516015499d09ee773a
Headers show
Series
  • utils: rkisp1: Miscellaneous capture script updates
Related show

Commit Message

Laurent Pinchart June 20, 2022, 9:06 p.m. UTC
The regexp to convert the raw pixel media bus code to a pixel format is
incorrect. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 utils/rkisp1/rkisp1-capture.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicolas Dufresne via libcamera-devel July 15, 2022, 7:31 a.m. UTC | #1
Hi Laurent,

On Tue, Jun 21, 2022 at 12:06:57AM +0300, Laurent Pinchart via libcamera-devel wrote:
> The regexp to convert the raw pixel media bus code to a pixel format is
> incorrect. Fix it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  utils/rkisp1/rkisp1-capture.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh
> index eee6b8027261..2549779d0f78 100755
> --- a/utils/rkisp1/rkisp1-capture.sh
> +++ b/utils/rkisp1/rkisp1-capture.sh
> @@ -171,7 +171,7 @@ mediactl="media-ctl -d $mdev"
>  
>  get_sensor_format "$sensor"
>  if [[ $raw == true ]] ; then
> -	capture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]$//')
> +	capture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]*$//')
>  	capture_mbus_code=$sensor_mbus_code
>  else
>  	capture_format=YUYV

Patch
diff mbox series

diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh
index eee6b8027261..2549779d0f78 100755
--- a/utils/rkisp1/rkisp1-capture.sh
+++ b/utils/rkisp1/rkisp1-capture.sh
@@ -171,7 +171,7 @@  mediactl="media-ctl -d $mdev"
 
 get_sensor_format "$sensor"
 if [[ $raw == true ]] ; then
-	capture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]$//')
+	capture_format=$(echo $sensor_mbus_code | sed 's/_[0-9X]*$//')
 	capture_mbus_code=$sensor_mbus_code
 else
 	capture_format=YUYV