| Message ID | 20220620014305.26778-7-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Mon, Jun 20, 2022 at 04:42:59AM +0300, Laurent Pinchart wrote: > To help attribute messages logged by the Module class to a particular > IPA module, make the class loggable and add a name argument to its > constructor to specify the log prefix. Where's the logPrefix? And the name argument to the constructor? Paul > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/libipa/module.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h > index 00d5785e1aa0..cd67912f1b0c 100644 > --- a/src/ipa/libipa/module.h > +++ b/src/ipa/libipa/module.h > @@ -27,7 +27,7 @@ namespace ipa { > > template<typename _Context, typename _FrameContext, typename _Config, > typename _Params, typename _Stats> > -class Module > +class Module : public Loggable > { > public: > using Context = _Context;
Hi Paul, On Thu, Jun 23, 2022 at 04:51:04PM +0900, paul.elder@ideasonboard.com wrote: > Hi Laurent, > > On Mon, Jun 20, 2022 at 04:42:59AM +0300, Laurent Pinchart wrote: > > To help attribute messages logged by the Module class to a particular > > IPA module, make the class loggable and add a name argument to its > > constructor to specify the log prefix. > > Where's the logPrefix? And the name argument to the constructor? I forgot to update the commit message after changing the implementation, oops. The logPrefix() function is now implemented by the Module subclasses. I'll fix this in v5. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/ipa/libipa/module.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h > > index 00d5785e1aa0..cd67912f1b0c 100644 > > --- a/src/ipa/libipa/module.h > > +++ b/src/ipa/libipa/module.h > > @@ -27,7 +27,7 @@ namespace ipa { > > > > template<typename _Context, typename _FrameContext, typename _Config, > > typename _Params, typename _Stats> > > -class Module > > +class Module : public Loggable > > { > > public: > > using Context = _Context;
diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h index 00d5785e1aa0..cd67912f1b0c 100644 --- a/src/ipa/libipa/module.h +++ b/src/ipa/libipa/module.h @@ -27,7 +27,7 @@ namespace ipa { template<typename _Context, typename _FrameContext, typename _Config, typename _Params, typename _Stats> -class Module +class Module : public Loggable { public: using Context = _Context;
To help attribute messages logged by the Module class to a particular IPA module, make the class loggable and add a name argument to its constructor to specify the log prefix. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/libipa/module.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)