| Message ID | 20220620014305.26778-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Mon, Jun 20, 2022 at 04:42:55AM +0300, Laurent Pinchart wrote: > The libipa.cpp file exists for the sole purpose of documentating the ipa > namespace. As we now have a top-level module.cpp file in libipa, move > the documentation there, and drop libipa.cpp. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/ipa/libipa/libipa.cpp | 22 ---------------------- > src/ipa/libipa/meson.build | 1 - > src/ipa/libipa/module.cpp | 7 +++++++ > 3 files changed, 7 insertions(+), 23 deletions(-) > delete mode 100644 src/ipa/libipa/libipa.cpp > > diff --git a/src/ipa/libipa/libipa.cpp b/src/ipa/libipa/libipa.cpp > deleted file mode 100644 > index 08bc3541f4eb..000000000000 > --- a/src/ipa/libipa/libipa.cpp > +++ /dev/null > @@ -1,22 +0,0 @@ > -/* SPDX-License-Identifier: LGPL-2.1-or-later */ > -/* > - * Copyright (C) 2021, Ideas On Board > - * > - * libipa.cpp - libipa interface > - */ > - > -namespace libcamera { > - > -/** > - * \brief The IPA namespace > - * > - * The IPA namespace groups all types specific to IPA modules. It serves as the > - * top-level namespace for the IPA library libipa, and also contains > - * module-specific namespaces for IPA modules. > - */ > -namespace ipa { > - > -} /* namespace ipa */ > - > -} /* namespace libcamera */ > - > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build > index 465cf7d6c4a7..fb894bc614af 100644 > --- a/src/ipa/libipa/meson.build > +++ b/src/ipa/libipa/meson.build > @@ -11,7 +11,6 @@ libipa_sources = files([ > 'algorithm.cpp', > 'camera_sensor_helper.cpp', > 'histogram.cpp', > - 'libipa.cpp', > 'module.cpp', > ]) > > diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp > index 5a6f49a80e6d..d03cc8ef03ed 100644 > --- a/src/ipa/libipa/module.cpp > +++ b/src/ipa/libipa/module.cpp > @@ -14,6 +14,13 @@ > > namespace libcamera { > > +/** > + * \brief The IPA namespace > + * > + * The IPA namespace groups all types specific to IPA modules. It serves as the > + * top-level namespace for the IPA library libipa, and also contains > + * module-specific namespaces for IPA modules. > + */ > namespace ipa { > > /** > -- > Regards, > > Laurent Pinchart >
diff --git a/src/ipa/libipa/libipa.cpp b/src/ipa/libipa/libipa.cpp deleted file mode 100644 index 08bc3541f4eb..000000000000 --- a/src/ipa/libipa/libipa.cpp +++ /dev/null @@ -1,22 +0,0 @@ -/* SPDX-License-Identifier: LGPL-2.1-or-later */ -/* - * Copyright (C) 2021, Ideas On Board - * - * libipa.cpp - libipa interface - */ - -namespace libcamera { - -/** - * \brief The IPA namespace - * - * The IPA namespace groups all types specific to IPA modules. It serves as the - * top-level namespace for the IPA library libipa, and also contains - * module-specific namespaces for IPA modules. - */ -namespace ipa { - -} /* namespace ipa */ - -} /* namespace libcamera */ - diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build index 465cf7d6c4a7..fb894bc614af 100644 --- a/src/ipa/libipa/meson.build +++ b/src/ipa/libipa/meson.build @@ -11,7 +11,6 @@ libipa_sources = files([ 'algorithm.cpp', 'camera_sensor_helper.cpp', 'histogram.cpp', - 'libipa.cpp', 'module.cpp', ]) diff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp index 5a6f49a80e6d..d03cc8ef03ed 100644 --- a/src/ipa/libipa/module.cpp +++ b/src/ipa/libipa/module.cpp @@ -14,6 +14,13 @@ namespace libcamera { +/** + * \brief The IPA namespace + * + * The IPA namespace groups all types specific to IPA modules. It serves as the + * top-level namespace for the IPA library libipa, and also contains + * module-specific namespaces for IPA modules. + */ namespace ipa { /**
The libipa.cpp file exists for the sole purpose of documentating the ipa namespace. As we now have a top-level module.cpp file in libipa, move the documentation there, and drop libipa.cpp. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/libipa/libipa.cpp | 22 ---------------------- src/ipa/libipa/meson.build | 1 - src/ipa/libipa/module.cpp | 7 +++++++ 3 files changed, 7 insertions(+), 23 deletions(-) delete mode 100644 src/ipa/libipa/libipa.cpp