[libcamera-devel,RFC,04/12] test: yaml-parser: Use write() instead of fwrite()
diff mbox series

Message ID 20220524225816.6830-5-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Replace boost JSON parser with libyaml in Raspberry Pi IPA
Related show

Commit Message

Laurent Pinchart May 24, 2022, 10:58 p.m. UTC 
There's no point in wrapping a fd into a FILE to then only call fwrite()
and fclose(). Use write() and close() directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 test/yaml-parser.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp
index 959a657478fa..944b564bbe22 100644
--- a/test/yaml-parser.cpp
+++ b/test/yaml-parser.cpp
@@ -48,10 +48,11 @@  protected:
 		if (fd == -1)
 			return false;
 
-		FILE *fh = fdopen(fd, "w");
-		fputs(content.c_str(), fh);
+		int ret = write(fd, content.c_str(), content.size());
+		close(fd);
 
-		fclose(fh);
+		if (ret != static_cast<int>(content.size()))
+			return false;
 
 		return true;
 	}