[libcamera-devel] test: Allow self-contained tests to run in parallel
diff mbox series

Message ID 20190704012656.14188-1-niklas.soderlund@ragnatech.se
State Accepted
Commit cea3ecc8e10fc00c93e4c1331430f06c0a936eb7
Headers show
Series
  • [libcamera-devel] test: Allow self-contained tests to run in parallel
Related show

Commit Message

Niklas Söderlund July 4, 2019, 1:26 a.m. UTC 
The IPA, IPC and Stream tests are self-contained so they can run in
parallel.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 test/ipa/meson.build    | 2 +-
 test/ipc/meson.build    | 2 +-
 test/stream/meson.build | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Kieran Bingham July 4, 2019, 7:38 a.m. UTC | #1 
Hi Niklas,

I have a very similar patch locally, but you win the race :-D

On 04/07/2019 02:26, Niklas Söderlund wrote:
> The IPA, IPC and Stream tests are self-contained so they can run in
> parallel.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  test/ipa/meson.build    | 2 +-
>  test/ipc/meson.build    | 2 +-
>  test/stream/meson.build | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/ipa/meson.build b/test/ipa/meson.build
> index bca39fa3f6d06ae4..1749ab7d43381fd7 100644
> --- a/test/ipa/meson.build
> +++ b/test/ipa/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipa_test
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipa', is_parallel : false)
> +    test(t[0], exe, suite : 'ipa')
>  endforeach
> diff --git a/test/ipc/meson.build b/test/ipc/meson.build
> index ca8375f35df91731..cc46b41c76870def 100644
> --- a/test/ipc/meson.build
> +++ b/test/ipc/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipc_tests
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipc', is_parallel : false)
> +    test(t[0], exe, suite : 'ipc')
>  endforeach
> diff --git a/test/stream/meson.build b/test/stream/meson.build
> index 2f2493de38ae0954..005f4aa4996ad563 100644
> --- a/test/stream/meson.build
> +++ b/test/stream/meson.build
> @@ -7,5 +7,5 @@ foreach t : stream_tests
>                     dependencies : libcamera_dep,
>                     link_with : test_libraries,
>                     include_directories : test_includes_internal)
> -  test(t[0], exe, suite: 'stream', is_parallel: false)
> +  test(t[0], exe, suite: 'stream')
>  endforeach
>
Laurent Pinchart July 4, 2019, 8:30 a.m. UTC | #2 
Hi Niklas,

Thank you for the patch.

On Thu, Jul 04, 2019 at 03:26:56AM +0200, Niklas Söderlund wrote:
> The IPA, IPC and Stream tests are self-contained so they can run in
> parallel.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  test/ipa/meson.build    | 2 +-
>  test/ipc/meson.build    | 2 +-
>  test/stream/meson.build | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/ipa/meson.build b/test/ipa/meson.build
> index bca39fa3f6d06ae4..1749ab7d43381fd7 100644
> --- a/test/ipa/meson.build
> +++ b/test/ipa/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipa_test
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipa', is_parallel : false)
> +    test(t[0], exe, suite : 'ipa')
>  endforeach
> diff --git a/test/ipc/meson.build b/test/ipc/meson.build
> index ca8375f35df91731..cc46b41c76870def 100644
> --- a/test/ipc/meson.build
> +++ b/test/ipc/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipc_tests
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipc', is_parallel : false)
> +    test(t[0], exe, suite : 'ipc')
>  endforeach
> diff --git a/test/stream/meson.build b/test/stream/meson.build
> index 2f2493de38ae0954..005f4aa4996ad563 100644
> --- a/test/stream/meson.build
> +++ b/test/stream/meson.build
> @@ -7,5 +7,5 @@ foreach t : stream_tests
>                     dependencies : libcamera_dep,
>                     link_with : test_libraries,
>                     include_directories : test_includes_internal)
> -  test(t[0], exe, suite: 'stream', is_parallel: false)
> +  test(t[0], exe, suite: 'stream')
>  endforeach
Niklas Söderlund July 4, 2019, 2:44 p.m. UTC | #3 
Hi,

I have pushed this patch to master with Kierans and Laurents tags.

On 2019-07-04 03:26:56 +0200, Niklas Söderlund wrote:
> The IPA, IPC and Stream tests are self-contained so they can run in
> parallel.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  test/ipa/meson.build    | 2 +-
>  test/ipc/meson.build    | 2 +-
>  test/stream/meson.build | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/ipa/meson.build b/test/ipa/meson.build
> index bca39fa3f6d06ae4..1749ab7d43381fd7 100644
> --- a/test/ipa/meson.build
> +++ b/test/ipa/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipa_test
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipa', is_parallel : false)
> +    test(t[0], exe, suite : 'ipa')
>  endforeach
> diff --git a/test/ipc/meson.build b/test/ipc/meson.build
> index ca8375f35df91731..cc46b41c76870def 100644
> --- a/test/ipc/meson.build
> +++ b/test/ipc/meson.build
> @@ -8,5 +8,5 @@ foreach t : ipc_tests
>                       link_with : test_libraries,
>                       include_directories : test_includes_internal)
>  
> -    test(t[0], exe, suite : 'ipc', is_parallel : false)
> +    test(t[0], exe, suite : 'ipc')
>  endforeach
> diff --git a/test/stream/meson.build b/test/stream/meson.build
> index 2f2493de38ae0954..005f4aa4996ad563 100644
> --- a/test/stream/meson.build
> +++ b/test/stream/meson.build
> @@ -7,5 +7,5 @@ foreach t : stream_tests
>                     dependencies : libcamera_dep,
>                     link_with : test_libraries,
>                     include_directories : test_includes_internal)
> -  test(t[0], exe, suite: 'stream', is_parallel: false)
> +  test(t[0], exe, suite: 'stream')
>  endforeach
> -- 
> 2.22.0
>

Patch
diff mbox series 

diff --git a/test/ipa/meson.build b/test/ipa/meson.build
index bca39fa3f6d06ae4..1749ab7d43381fd7 100644
--- a/test/ipa/meson.build
+++ b/test/ipa/meson.build
@@ -8,5 +8,5 @@  foreach t : ipa_test
                      link_with : test_libraries,
                      include_directories : test_includes_internal)
 
-    test(t[0], exe, suite : 'ipa', is_parallel : false)
+    test(t[0], exe, suite : 'ipa')
 endforeach
diff --git a/test/ipc/meson.build b/test/ipc/meson.build
index ca8375f35df91731..cc46b41c76870def 100644
--- a/test/ipc/meson.build
+++ b/test/ipc/meson.build
@@ -8,5 +8,5 @@  foreach t : ipc_tests
                      link_with : test_libraries,
                      include_directories : test_includes_internal)
 
-    test(t[0], exe, suite : 'ipc', is_parallel : false)
+    test(t[0], exe, suite : 'ipc')
 endforeach
diff --git a/test/stream/meson.build b/test/stream/meson.build
index 2f2493de38ae0954..005f4aa4996ad563 100644
--- a/test/stream/meson.build
+++ b/test/stream/meson.build
@@ -7,5 +7,5 @@  foreach t : stream_tests
                    dependencies : libcamera_dep,
                    link_with : test_libraries,
                    include_directories : test_includes_internal)
-  test(t[0], exe, suite: 'stream', is_parallel: false)
+  test(t[0], exe, suite: 'stream')
 endforeach