| Message ID | 20190703080007.21376-7-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Wed, Jul 03, 2019 at 05:00:06PM +0900, Paul Elder wrote: > Add a dummy IPA that needs to be isolated. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > Changes in v2: > - ipaModuleInfo contains license rather than "please isolate me" > > src/ipa/ipa_dummy_isolate.cpp | 46 +++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 src/ipa/ipa_dummy_isolate.cpp > > diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp > new file mode 100644 > index 0000000..f546f43 > --- /dev/null > +++ b/src/ipa/ipa_dummy_isolate.cpp > @@ -0,0 +1,46 @@ > +/* SPDX-License-Identifier: LGPL-2.1-or-later */ > +/* > + * Copyright (C) 2019, Google Inc. > + * > + * ipa_dummy.cpp - Dummy Image Processing Algorithm module I think you forgot to update this. > + */ > + > +#include <iostream> > + > +#include <libcamera/ipa/ipa_interface.h> > +#include <libcamera/ipa/ipa_module_info.h> > + > +namespace libcamera { > + > +class IPADummyIsolate : public IPAInterface > +{ > +public: > + int init(); > +}; > + > +int IPADummyIsolate::init() > +{ > + std::cout << "initializing dummy IPA!" << std::endl; I would mention here that the IPA is isolated. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I however think this will need to be moved to the test directory as such a module is really not useful in production. The ipa_dummy should probably be moved there as well. Should we do so already as part of this patch series ? > + return 0; > +} > + > +/* > + * External IPA module interface > + */ > + > +extern "C" { > +const struct IPAModuleInfo ipaModuleInfo = { > + IPA_MODULE_API_VERSION, > + 0, > + "PipelineHandlerVimc", > + "Dummy IPA for Vimc that needs to be isolated", > + "Proprietary", > +}; > + > +IPAInterface *ipaCreate() > +{ > + return new IPADummyIsolate(); > +} > +}; > + > +}; /* namespace libcamera */
diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp new file mode 100644 index 0000000..f546f43 --- /dev/null +++ b/src/ipa/ipa_dummy_isolate.cpp @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2019, Google Inc. + * + * ipa_dummy.cpp - Dummy Image Processing Algorithm module + */ + +#include <iostream> + +#include <libcamera/ipa/ipa_interface.h> +#include <libcamera/ipa/ipa_module_info.h> + +namespace libcamera { + +class IPADummyIsolate : public IPAInterface +{ +public: + int init(); +}; + +int IPADummyIsolate::init() +{ + std::cout << "initializing dummy IPA!" << std::endl; + return 0; +} + +/* + * External IPA module interface + */ + +extern "C" { +const struct IPAModuleInfo ipaModuleInfo = { + IPA_MODULE_API_VERSION, + 0, + "PipelineHandlerVimc", + "Dummy IPA for Vimc that needs to be isolated", + "Proprietary", +}; + +IPAInterface *ipaCreate() +{ + return new IPADummyIsolate(); +} +}; + +}; /* namespace libcamera */
Add a dummy IPA that needs to be isolated. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- Changes in v2: - ipaModuleInfo contains license rather than "please isolate me" src/ipa/ipa_dummy_isolate.cpp | 46 +++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 src/ipa/ipa_dummy_isolate.cpp