[libcamera-devel,v2,01/13] py: meson: fix comment about stubs
diff mbox series

Message ID 20220517143325.71784-2-tomi.valkeinen@ideasonboard.com
State Superseded
Headers show
Series
  • Misc Python bindings patches
Related show

Commit Message

Tomi Valkeinen May 17, 2022, 2:33 p.m. UTC
At least pyright seems to be able to use the stubs from the
libcamera-stubs directory, so no need to copy the generated files.
Adjust the comment accordingly.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/py/libcamera/meson.build | 1 -
 1 file changed, 1 deletion(-)

Comments

Kieran Bingham May 17, 2022, 4:08 p.m. UTC | #1
Quoting Tomi Valkeinen (2022-05-17 15:33:13)
> At least pyright seems to be able to use the stubs from the
> libcamera-stubs directory, so no need to copy the generated files.
> Adjust the comment accordingly.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Seems trivial.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/py/libcamera/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
> index 0cd7c75b..38f619d0 100644
> --- a/src/py/libcamera/meson.build
> +++ b/src/py/libcamera/meson.build
> @@ -63,4 +63,3 @@ install_data(['__init__.py'], install_dir : destdir)
>  # \todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files
>  # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs:
>  # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera
> -# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/
> -- 
> 2.34.1
>

Patch
diff mbox series

diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
index 0cd7c75b..38f619d0 100644
--- a/src/py/libcamera/meson.build
+++ b/src/py/libcamera/meson.build
@@ -63,4 +63,3 @@  install_data(['__init__.py'], install_dir : destdir)
 # \todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files
 # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs:
 # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera
-# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/