| Message ID | 20220516141022.96327-15-tomi.valkeinen@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Tomi, Thank you for the patch. On Mon, May 16, 2022 at 05:10:22PM +0300, Tomi Valkeinen wrote: > Instead of doing an atomic commit for each stream, do a single commit > for the two planes. This fixes the issue that only the first plane was > actually shown. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/py/cam/cam_kms.py | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py > index 90aac5f6..74cd3b38 100644 > --- a/src/py/cam/cam_kms.py > +++ b/src/py/cam/cam_kms.py > @@ -67,12 +67,13 @@ class KMSRenderer: > > buffers = drmreq['camreq'].buffers > > + req = pykms.AtomicReq(self.card) > + > for stream, fb in buffers.items(): > drmfb = self.cam_2_drm.get(fb, None) > - > - req = pykms.AtomicReq(self.card) > self.add_plane(req, stream, drmfb) > - req.commit() > + > + req.commit() > > def handle_page_flip(self, frame, time): > old = self.current
diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py index 90aac5f6..74cd3b38 100644 --- a/src/py/cam/cam_kms.py +++ b/src/py/cam/cam_kms.py @@ -67,12 +67,13 @@ class KMSRenderer: buffers = drmreq['camreq'].buffers + req = pykms.AtomicReq(self.card) + for stream, fb in buffers.items(): drmfb = self.cam_2_drm.get(fb, None) - - req = pykms.AtomicReq(self.card) self.add_plane(req, stream, drmfb) - req.commit() + + req.commit() def handle_page_flip(self, frame, time): old = self.current
Instead of doing an atomic commit for each stream, do a single commit for the two planes. This fixes the issue that only the first plane was actually shown. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- src/py/cam/cam_kms.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)