| Message ID | 20220516141022.96327-2-tomi.valkeinen@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Tomi, Thank you for the patch. On Mon, May 16, 2022 at 05:10:09PM +0300, Tomi Valkeinen wrote: > At least pyright seems to be able to use the stubs from the > libcamera-stubs directory, so no need to copy the generated files. > Adjust the comment accordingly. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/py/libcamera/meson.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build > index 0cd7c75b..38f619d0 100644 > --- a/src/py/libcamera/meson.build > +++ b/src/py/libcamera/meson.build > @@ -63,4 +63,3 @@ install_data(['__init__.py'], install_dir : destdir) > # \todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files > # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs: > # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera > -# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/
diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build index 0cd7c75b..38f619d0 100644 --- a/src/py/libcamera/meson.build +++ b/src/py/libcamera/meson.build @@ -63,4 +63,3 @@ install_data(['__init__.py'], install_dir : destdir) # \todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs: # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera -# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/
At least pyright seems to be able to use the stubs from the libcamera-stubs directory, so no need to copy the generated files. Adjust the comment accordingly. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- src/py/libcamera/meson.build | 1 - 1 file changed, 1 deletion(-)