[libcamera-devel,2/2] libipa: camera_sensor_helper: Add OV5675 helper

15762 diff mbox series

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

The OV5675 is an OmniVision sensor with a linear gain model, expressed
in 1/128 steps.

Cc: Quentin Schulz <foss+libcamera@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

Hi Quentin

On Tue, May 03, 2022 at 05:57:25PM +0200, Quentin Schulz via libcamera-devel wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The OV5675 is an OmniVision sensor with a linear gain model, expressed
> in 1/128 steps.
>

Likewise, no datasheet, but patch looks good
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

> Cc: Quentin Schulz <foss+libcamera@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index c098e48c..0f156137 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -429,6 +429,17 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("ov5670", CameraSensorHelperOv5670)
>
> +class CameraSensorHelperOv5675 : public CameraSensorHelper
> +{
> +public:
> +	CameraSensorHelperOv5675()
> +	{
> +		gainType_ = AnalogueGainLinear;
> +		gainConstants_.linear = { 1, 0, 0, 128 };
> +	}
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("ov5675", CameraSensorHelperOv5675)
> +
>  class CameraSensorHelperOv5693 : public CameraSensorHelper
>  {
>  public:
> --
> 2.35.1
>

Quoting Jacopo Mondi via libcamera-devel (2022-05-04 07:17:18)
> Hi Quentin
> 
> On Tue, May 03, 2022 at 05:57:25PM +0200, Quentin Schulz via libcamera-devel wrote:
> > From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> >
> > The OV5675 is an OmniVision sensor with a linear gain model, expressed
> > in 1/128 steps.
> >
> 
> Likewise, no datasheet, but patch looks good
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> 

Same, the brief doesn't have enough information to say one way or
another here, but I think this looks suitable to get started.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Thanks
>    j
> 
> > Cc: Quentin Schulz <foss+libcamera@0leil.net>
> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > ---
> >  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> > index c098e48c..0f156137 100644
> > --- a/src/ipa/libipa/camera_sensor_helper.cpp
> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> > @@ -429,6 +429,17 @@ public:
> >  };
> >  REGISTER_CAMERA_SENSOR_HELPER("ov5670", CameraSensorHelperOv5670)
> >
> > +class CameraSensorHelperOv5675 : public CameraSensorHelper
> > +{
> > +public:
> > +     CameraSensorHelperOv5675()
> > +     {
> > +             gainType_ = AnalogueGainLinear;
> > +             gainConstants_.linear = { 1, 0, 0, 128 };
> > +     }
> > +};
> > +REGISTER_CAMERA_SENSOR_HELPER("ov5675", CameraSensorHelperOv5675)
> > +
> >  class CameraSensorHelperOv5693 : public CameraSensorHelper
> >  {
> >  public:
> > --
> > 2.35.1
> >