[libcamera-devel,1/5] libcamera: geometry: Add missing ostream header in geometry.h
diff mbox series

Message ID 20220429212348.18063-2-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: More operator<<() for stream output
Related show

Commit Message

Laurent Pinchart April 29, 2022, 9:23 p.m. UTC
Commit c730dc74795d ("libcamera: geometry: Add operator<< for classes in
geometry") added usage of std::ostream in geometry.h but forget to
include the corresponding header. Fix it to avoid future compilation
breakages if indirect inclusions are changed.

Fixes: c730dc74795d ("libcamera: geometry: Add operator<< for classes in geometry")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/geometry.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham May 4, 2022, 8:54 a.m. UTC | #1
Quoting Laurent Pinchart via libcamera-devel (2022-04-29 22:23:44)
> Commit c730dc74795d ("libcamera: geometry: Add operator<< for classes in
> geometry") added usage of std::ostream in geometry.h but forget to
> include the corresponding header. Fix it to avoid future compilation
> breakages if indirect inclusions are changed.
> 
> Fixes: c730dc74795d ("libcamera: geometry: Add operator<< for classes in geometry")

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  include/libcamera/geometry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h
> index d4a144bcd42a..d7fdbe708e6d 100644
> --- a/include/libcamera/geometry.h
> +++ b/include/libcamera/geometry.h
> @@ -8,6 +8,7 @@
>  #pragma once
>  
>  #include <algorithm>
> +#include <ostream>
>  #include <string>
>  
>  #include <libcamera/base/compiler.h>
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series

diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h
index d4a144bcd42a..d7fdbe708e6d 100644
--- a/include/libcamera/geometry.h
+++ b/include/libcamera/geometry.h
@@ -8,6 +8,7 @@ 
 #pragma once
 
 #include <algorithm>
+#include <ostream>
 #include <string>
 
 #include <libcamera/base/compiler.h>