| Message ID | 20190106023328.10989-8-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for your patch. On 2019-01-06 04:33:25 +0200, Laurent Pinchart wrote: > The list test generates a list binary in the test directory, which > conflicts with the C++ std::list header of the same name. The binary > gets included instead of the header file, breaking compilation. > > Rename the test to avoid this. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/meson.build b/test/meson.build > index 184a7eeb5e27..638e8d51c131 100644 > --- a/test/meson.build > +++ b/test/meson.build > @@ -3,7 +3,7 @@ subdir('libtest') > subdir('media_device') > > public_tests = [ > - ['list', 'list.cpp'], > + ['list-cameras', 'list.cpp'], I would rename the cpp file as well to match the binary name. With this fixed Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > ] > > internal_tests = [ > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/test/meson.build b/test/meson.build index 184a7eeb5e27..638e8d51c131 100644 --- a/test/meson.build +++ b/test/meson.build @@ -3,7 +3,7 @@ subdir('libtest') subdir('media_device') public_tests = [ - ['list', 'list.cpp'], + ['list-cameras', 'list.cpp'], ] internal_tests = [
The list test generates a list binary in the test directory, which conflicts with the C++ std::list header of the same name. The binary gets included instead of the header file, breaking compilation. Rename the test to avoid this. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- test/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)