| Message ID | 20220406123805.4045928-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thank you for the patch. On Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via libcamera-devel wrote: > s/prevetn/prevent/ > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/v4l2_videodevice.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp > index 0830be80c553..98671509fe02 100644 > --- a/src/libcamera/v4l2_videodevice.cpp > +++ b/src/libcamera/v4l2_videodevice.cpp > @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer() > * not find it in the queuedBuffers_ list. > * > * Whilst this kernel bug has been fixed in mainline, ensure that we > - * safely ingore buffers which are unexpected to prevetn crashes on > + * safely ingore buffers which are unexpected to prevent crashes on While at it, s/ingore/ignore/ ? :-) I'll fix that locally. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > * older kernels. > */ > auto it = queuedBuffers_.find(buf.index);
On Wed, 6 Apr 2022 at 13:42, Laurent Pinchart < laurent.pinchart@ideasonboard.com> wrote: > Hi Naush, > > Thank you for the patch. > > On Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via > libcamera-devel wrote: > > s/prevetn/prevent/ > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > --- > > src/libcamera/v4l2_videodevice.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/v4l2_videodevice.cpp > b/src/libcamera/v4l2_videodevice.cpp > > index 0830be80c553..98671509fe02 100644 > > --- a/src/libcamera/v4l2_videodevice.cpp > > +++ b/src/libcamera/v4l2_videodevice.cpp > > @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer() > > * not find it in the queuedBuffers_ list. > > * > > * Whilst this kernel bug has been fixed in mainline, ensure that > we > > - * safely ingore buffers which are unexpected to prevetn crashes on > > + * safely ingore buffers which are unexpected to prevent crashes on > > While at it, s/ingore/ignore/ ? :-) I'll fix that locally. > Haha, I can't believe I missed that! > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > * older kernels. > > */ > > auto it = queuedBuffers_.find(buf.index); > > -- > Regards, > > Laurent Pinchart >
Hello, On 4/6/22 18:12, Laurent Pinchart via libcamera-devel wrote: > Hi Naush, > > Thank you for the patch. > > On Wed, Apr 06, 2022 at 01:38:05PM +0100, Naushir Patuck via libcamera-devel wrote: >> s/prevetn/prevent/ >> >> Signed-off-by: Naushir Patuck <naush@raspberrypi.com> >> --- >> src/libcamera/v4l2_videodevice.cpp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp >> index 0830be80c553..98671509fe02 100644 >> --- a/src/libcamera/v4l2_videodevice.cpp >> +++ b/src/libcamera/v4l2_videodevice.cpp >> @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer() >> * not find it in the queuedBuffers_ list. >> * >> * Whilst this kernel bug has been fixed in mainline, ensure that we >> - * safely ingore buffers which are unexpected to prevetn crashes on >> + * safely ingore buffers which are unexpected to prevent crashes on > While at it, s/ingore/ignore/ ? :-) I'll fix that locally. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > >> * older kernels. >> */ >> auto it = queuedBuffers_.find(buf.index);
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 0830be80c553..98671509fe02 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -1715,7 +1715,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer() * not find it in the queuedBuffers_ list. * * Whilst this kernel bug has been fixed in mainline, ensure that we - * safely ingore buffers which are unexpected to prevetn crashes on + * safely ingore buffers which are unexpected to prevent crashes on * older kernels. */ auto it = queuedBuffers_.find(buf.index);
s/prevetn/prevent/ Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/v4l2_videodevice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)