| Message ID | 20220328120404.10880-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 0040820fc175a202f12d41f9b18e91e1e540d0df |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Mon, Mar 28, 2022 at 03:04:04PM +0300, Laurent Pinchart via libcamera-devel wrote: > From: Paul Elder <paul.elder@ideasonboard.com> > > The OV5640 is am OmniVision sensor with a linear gain model, expressed > in 1/16 steps. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 0ec51f4e0753..c098e48cdfe0 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -407,6 +407,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) > > +class CameraSensorHelperOv5640 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperOv5640() > + { > + gainType_ = AnalogueGainLinear; > + gainConstants_.linear = { 1, 0, 0, 16 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640) > + > class CameraSensorHelperOv5670 : public CameraSensorHelper > { > public: > -- > Regards, > > Laurent Pinchart >
Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04) > From: Paul Elder <paul.elder@ideasonboard.com> Missing SoB. > > The OV5640 is am OmniVision sensor with a linear gain model, expressed > in 1/16 steps. > /am/an/ Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 0ec51f4e0753..c098e48cdfe0 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -407,6 +407,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) > > +class CameraSensorHelperOv5640 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperOv5640() > + { > + gainType_ = AnalogueGainLinear; > + gainConstants_.linear = { 1, 0, 0, 16 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640) > + > class CameraSensorHelperOv5670 : public CameraSensorHelper > { > public: > -- > Regards, > > Laurent Pinchart >
On Mon, Mar 28, 2022 at 02:21:33PM +0100, Kieran Bingham wrote: > Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04) > > From: Paul Elder <paul.elder@ideasonboard.com> > > Missing SoB. Oops. Paul, could you please reply with your SoB line ? > > The OV5640 is am OmniVision sensor with a linear gain model, expressed > > in 1/16 steps. > > /am/an/ > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > > index 0ec51f4e0753..c098e48cdfe0 100644 > > --- a/src/ipa/libipa/camera_sensor_helper.cpp > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > > @@ -407,6 +407,17 @@ public: > > }; > > REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) > > > > +class CameraSensorHelperOv5640 : public CameraSensorHelper > > +{ > > +public: > > + CameraSensorHelperOv5640() > > + { > > + gainType_ = AnalogueGainLinear; > > + gainConstants_.linear = { 1, 0, 0, 16 }; > > + } > > +}; > > +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640) > > + > > class CameraSensorHelperOv5670 : public CameraSensorHelper > > { > > public:
On Mon, Mar 28, 2022 at 04:40:56PM +0300, Laurent Pinchart wrote: > On Mon, Mar 28, 2022 at 02:21:33PM +0100, Kieran Bingham wrote: > > Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04) > > > From: Paul Elder <paul.elder@ideasonboard.com> > > > > Missing SoB. > > Oops. Paul, could you please reply with your SoB line ? Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > The OV5640 is am OmniVision sensor with a linear gain model, expressed > > > in 1/16 steps. > > > > /am/an/ > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > > > index 0ec51f4e0753..c098e48cdfe0 100644 > > > --- a/src/ipa/libipa/camera_sensor_helper.cpp > > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > > > @@ -407,6 +407,17 @@ public: > > > }; > > > REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) > > > > > > +class CameraSensorHelperOv5640 : public CameraSensorHelper > > > +{ > > > +public: > > > + CameraSensorHelperOv5640() > > > + { > > > + gainType_ = AnalogueGainLinear; > > > + gainConstants_.linear = { 1, 0, 0, 16 }; > > > + } > > > +}; > > > +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640) > > > + > > > class CameraSensorHelperOv5670 : public CameraSensorHelper > > > { > > > public: > > -- > Regards, > > Laurent Pinchart
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 0ec51f4e0753..c098e48cdfe0 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -407,6 +407,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) +class CameraSensorHelperOv5640 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv5640() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 16 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640) + class CameraSensorHelperOv5670 : public CameraSensorHelper { public: