[libcamera-devel,4/4] libipa: camera_sensor_helper: Add IMX296 helper
diff mbox series

Message ID 20220328120336.10834-5-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • IPA sensor helpers for IMX290 and IMX296
Related show

Commit Message

Laurent Pinchart March 28, 2022, 12:03 p.m. UTC 
The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It
thus maps to the exponential gain model.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Jacopo Mondi March 29, 2022, 2:35 p.m. UTC | #1 
Hi Laurent

On Mon, Mar 28, 2022 at 03:03:36PM +0300, Laurent Pinchart via libcamera-devel wrote:
> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It
> thus maps to the exponential gain model.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 136b9f6bc3c5..0ec51f4e0753 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -385,6 +385,17 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
>
> +class CameraSensorHelperImx296 : public CameraSensorHelper
> +{
> +public:
> +	CameraSensorHelperImx296()
> +	{
> +		gainType_ = AnalogueGainExponential;
> +		gainConstants_.exp = { 1.0, expGainDb(0.1) };
> +	}
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
> +
>  class CameraSensorHelperOv2740 : public CameraSensorHelper
>  {
>  public:
> --
> Regards,
>
> Laurent Pinchart
>
Umang Jain March 30, 2022, 8:42 a.m. UTC | #2 
Hi,

On 3/28/22 17:33, Laurent Pinchart via libcamera-devel wrote:
> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It
> thus maps to the exponential gain model.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 136b9f6bc3c5..0ec51f4e0753 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -385,6 +385,17 @@ public:
>   };
>   REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
>   
> +class CameraSensorHelperImx296 : public CameraSensorHelper
> +{
> +public:
> +	CameraSensorHelperImx296()
> +	{
> +		gainType_ = AnalogueGainExponential;
> +		gainConstants_.exp = { 1.0, expGainDb(0.1) };
> +	}
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
> +
>   class CameraSensorHelperOv2740 : public CameraSensorHelper
>   {
>   public:
Nicolas Dufresne via libcamera-devel March 30, 2022, 8:46 a.m. UTC | #3 
Hi Laurent,

On Mon, Mar 28, 2022 at 03:03:36PM +0300, Laurent Pinchart via libcamera-devel wrote:
> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It
> thus maps to the exponential gain model.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 136b9f6bc3c5..0ec51f4e0753 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -385,6 +385,17 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
>  
> +class CameraSensorHelperImx296 : public CameraSensorHelper
> +{
> +public:
> +	CameraSensorHelperImx296()
> +	{
> +		gainType_ = AnalogueGainExponential;
> +		gainConstants_.exp = { 1.0, expGainDb(0.1) };
> +	}
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
> +
>  class CameraSensorHelperOv2740 : public CameraSensorHelper
>  {
>  public:

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 136b9f6bc3c5..0ec51f4e0753 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -385,6 +385,17 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
 
+class CameraSensorHelperImx296 : public CameraSensorHelper
+{
+public:
+	CameraSensorHelperImx296()
+	{
+		gainType_ = AnalogueGainExponential;
+		gainConstants_.exp = { 1.0, expGainDb(0.1) };
+	}
+};
+REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
+
 class CameraSensorHelperOv2740 : public CameraSensorHelper
 {
 public: