| Message ID | 20220326153116.11460-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 9bb0889bafe6269306e90db0a41a0db85fb76dfe |
| Headers | show |
| Series |
|
| Related | show |
Quoting Laurent Pinchart via libcamera-devel (2022-03-26 15:31:16) > Possibly the most trivial patch. Probably don't need that line when pushing ;-) but I can look the other way. Fix is correct so: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index c7292f66b17b..46fd02d207be 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -284,7 +284,7 @@ gst_libcamera_src_task_run(gpointer user_data) > &buffer, nullptr); > if (ret != GST_FLOW_OK) { > /* > - * RequestWrap has ownership of the rquest, and we > + * RequestWrap has ownership of the request, and we > * won't be queueing this one due to lack of buffers. > */ > wrap.release(); > -- > Regards, > > Laurent Pinchart >
On Sat, Mar 26, 2022 at 10:42:50PM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart via libcamera-devel (2022-03-26 15:31:16) > > Possibly the most trivial patch. > > Probably don't need that line when pushing ;-) but I can look the other > way. I was struggling finding anything else relevant to write :-) > Fix is correct so: > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/gstreamer/gstlibcamerasrc.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > > index c7292f66b17b..46fd02d207be 100644 > > --- a/src/gstreamer/gstlibcamerasrc.cpp > > +++ b/src/gstreamer/gstlibcamerasrc.cpp > > @@ -284,7 +284,7 @@ gst_libcamera_src_task_run(gpointer user_data) > > &buffer, nullptr); > > if (ret != GST_FLOW_OK) { > > /* > > - * RequestWrap has ownership of the rquest, and we > > + * RequestWrap has ownership of the request, and we > > * won't be queueing this one due to lack of buffers. > > */ > > wrap.release();
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index c7292f66b17b..46fd02d207be 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -284,7 +284,7 @@ gst_libcamera_src_task_run(gpointer user_data) &buffer, nullptr); if (ret != GST_FLOW_OK) { /* - * RequestWrap has ownership of the rquest, and we + * RequestWrap has ownership of the request, and we * won't be queueing this one due to lack of buffers. */ wrap.release();
Possibly the most trivial patch. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)