[libcamera-devel,v4] meson: reduce required version to 0.53
diff mbox series

Message ID 20211222102349.219005-1-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,v4] meson: reduce required version to 0.53
Related show

Commit Message

Kieran Bingham Dec. 22, 2021, 10:23 a.m. UTC 
From: Christian Rauch <Rauch.Christian@gmx.de>

Building the libcamera Android layer currently makes use of features
from meson 0.55. The core libcamera framework in the default configuration
without android enabled uses the 'summary' feature available in 0.53, and
is the lowest supportable meson version if the Android HAL is excluded.

Ubuntu 20.04 LTS currently provides meson 0.53 and represents an
acceptable minimum version to support. Platforms utilising the Android
component will have full control over their build environment and can
ensure that they provide a more recent version of meson.

Reduce the supported meson version for the project to 0.53 to facilitate
building on more distributions without having to manually update the
meson package.

Meson will output a warning that features not available in 0.53 are used
if the Android HAL is enabled. This is considered as an acceptable
middleground to improve the experience on the latest Ubuntu LTS, until
22.04 LTS is released and provides a newer meson version.

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
[Kieran: Add comment about the android meson requirements]
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
v4:
 - Took in Laurent's comments
 - Updated README.rst requirements

 README.rst  | 4 +++-
 meson.build | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index c48b4dbab85a..4575d8ee7f4e 100644
--- a/README.rst
+++ b/README.rst
@@ -47,7 +47,9 @@  A C++ toolchain: [required]
 	Either {g++, clang}
 
 Meson Build system: [required]
-        meson (>= 0.55) ninja-build pkg-config
+        meson (>= 0.53) ninja-build pkg-config
+
+        meson (>= 0.55) is required for building Android (-Dandroid=enabled)
 
         If your distribution doesn't provide a recent enough version of meson,
         you can install or upgrade it using pip3.
diff --git a/meson.build b/meson.build
index a20cc29e3749..9684d562828d 100644
--- a/meson.build
+++ b/meson.build
@@ -1,7 +1,11 @@ 
 # SPDX-License-Identifier: CC0-1.0
 
 project('libcamera', 'c', 'cpp',
-    meson_version : '>= 0.55',
+    # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS
+    # ships meson 0.53. Improve the Ubuntu experience at the expense of
+    # Android as the former is a much more common use case than the latter at
+    # this point. This should be fixed after Ubuntu releases 22.04 LTS.
+    meson_version : '>= 0.53',
     version : '0.0.0',
     default_options : [
         'werror=true',