[libcamera-devel,v3] meson: reduce required version to 0.53

15208 diff mbox series

From: Christian Rauch <Rauch.Christian@gmx.de>

Building the libcamera Android layer currently makes use of features
from meson 0.55. The core libcamera framework in the default configuration
without android enabled uses the 'summary' feature available in 0.53, and
is the lowest supportable meson version if the Android HAL is excluded.

Ubuntu 20.04 LTS currently provides meson 0.53 and represents an
acceptable minimum version to support. Platforms utilising the Android
component will have full control over their build environment and can
ensure that they provide a more recent version of meson.

Reduce the supported meson version for the project to 0.53 to facilitate
building on more distributions without having to manually update the
meson package.

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
[Kieran: Add comment about the android meson requirements]
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Hi Kieran,

Thank you for the patch.

On Tue, Dec 21, 2021 at 04:47:31PM +0000, Kieran Bingham wrote:
> From: Christian Rauch <Rauch.Christian@gmx.de>
> 
> Building the libcamera Android layer currently makes use of features
> from meson 0.55. The core libcamera framework in the default configuration
> without android enabled uses the 'summary' feature available in 0.53, and
> is the lowest supportable meson version if the Android HAL is excluded.
> 
> Ubuntu 20.04 LTS currently provides meson 0.53 and represents an
> acceptable minimum version to support. Platforms utilising the Android
> component will have full control over their build environment and can
> ensure that they provide a more recent version of meson.
> 
> Reduce the supported meson version for the project to 0.53 to facilitate
> building on more distributions without having to manually update the
> meson package.

I'd add

meson will output a warning that features not available in 0.53 are used
if the Android HAL is enabled. This is considered as an acceptable
middleground to improve the experience on the latest Ubuntu LTS, until
22.04 LTS is released and provides a newer meson version.

> Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
> [Kieran: Add comment about the android meson requirements]
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index a20cc29e3749..b8f2f254dcbb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,7 +1,8 @@
>  # SPDX-License-Identifier: CC0-1.0
>  
>  project('libcamera', 'c', 'cpp',
> -    meson_version : '>= 0.55',
> +    # Use of the Android component requires meson 0.55

Likewise,

    # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS
    # ships meson 0.53. Improve the Ubuntu experience at the expense of Android
    # as the former is a much more common use case than the latter at this
    # point. This should be fixed after Ubuntu releases 22.04 LTS.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +    meson_version : '>= 0.53',
>      version : '0.0.0',
>      default_options : [
>          'werror=true',

Quoting Laurent Pinchart (2021-12-21 17:04:12)
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Tue, Dec 21, 2021 at 04:47:31PM +0000, Kieran Bingham wrote:
> > From: Christian Rauch <Rauch.Christian@gmx.de>
> > 
> > Building the libcamera Android layer currently makes use of features
> > from meson 0.55. The core libcamera framework in the default configuration
> > without android enabled uses the 'summary' feature available in 0.53, and
> > is the lowest supportable meson version if the Android HAL is excluded.
> > 
> > Ubuntu 20.04 LTS currently provides meson 0.53 and represents an
> > acceptable minimum version to support. Platforms utilising the Android
> > component will have full control over their build environment and can
> > ensure that they provide a more recent version of meson.
> > 
> > Reduce the supported meson version for the project to 0.53 to facilitate
> > building on more distributions without having to manually update the
> > meson package.
> 
> I'd add
> 
> meson will output a warning that features not available in 0.53 are used
> if the Android HAL is enabled. This is considered as an acceptable
> middleground to improve the experience on the latest Ubuntu LTS, until
> 22.04 LTS is released and provides a newer meson version.
> 
> > Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
> > [Kieran: Add comment about the android meson requirements]
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > ---
> >  meson.build | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index a20cc29e3749..b8f2f254dcbb 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1,7 +1,8 @@
> >  # SPDX-License-Identifier: CC0-1.0
> >  
> >  project('libcamera', 'c', 'cpp',
> > -    meson_version : '>= 0.55',
> > +    # Use of the Android component requires meson 0.55
> 
> Likewise,
> 
>     # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS
>     # ships meson 0.53. Improve the Ubuntu experience at the expense of Android
>     # as the former is a much more common use case than the latter at this
>     # point. This should be fixed after Ubuntu releases 22.04 LTS.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Sure, I can add all that while applying.

I wondered if we shouldn't make this all about Ubuntu, but Debian stable
has meson 0.56, so it probably is just Ubuntu being behind everyone
else.

> > +    meson_version : '>= 0.53',
> >      version : '0.0.0',
> >      default_options : [
> >          'werror=true',
> 
> -- 
> Regards,
> 
> Laurent Pinchart