[libcamera-devel,1/4] libcamera: camera_sensor: Add IMX296 sensor properties
diff mbox series

Message ID 20211219232714.11427-2-laurent.pinchart@ideasonboard.com
State Accepted
Delegated to: Laurent Pinchart
Headers show
Series
  • libcamera: Add support for the IMX296 sensor in the Raspberry Pi IPA
Related show

Commit Message

Laurent Pinchart Dec. 19, 2021, 11:27 p.m. UTC
The Sony IMX296 is a global shutter sensor with a 1456x1088 pixel array
size, with a recommended resolution after CFA interpolation of
1440x1080.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/camera_sensor_properties.cpp | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Naushir Patuck Dec. 20, 2021, 7:36 a.m. UTC | #1
Hi Laurent,

Thank you for your work.

On Sun, 19 Dec 2021 at 23:27, Laurent Pinchart <
laurent.pinchart@ideasonboard.com> wrote:

> The Sony IMX296 is a global shutter sensor with a 1456x1088 pixel array
> size, with a recommended resolution after CFA interpolation of
> 1440x1080.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Naushir Patuck <naush <naushir@gmail.com>@raspberrypi.com>


> ---
>  src/libcamera/camera_sensor_properties.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/libcamera/camera_sensor_properties.cpp
> b/src/libcamera/camera_sensor_properties.cpp
> index 48305ac481ed..e0086691a61e 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -90,6 +90,10 @@ const CameraSensorProperties
> *CameraSensorProperties::get(const std::string &sen
>                                 { controls::draft::TestPatternModePn9, 4 },
>                         },
>                 } },
> +               { "imx296", {
> +                       .unitCellSize = { 3450, 3450 },
> +                       .testPatternModes = {},
> +               } },
>                 { "ov5647", {
>                         .unitCellSize = { 1400, 1400 },
>                         .testPatternModes = {},
> --
> Regards,
>
> Laurent Pinchart
>
>
Paul Elder via libcamera-devel March 17, 2022, 11:27 a.m. UTC | #2
Quoting Laurent Pinchart (2021-12-19 23:27:11)
> The Sony IMX296 is a global shutter sensor with a 1456x1088 pixel array
> size, with a recommended resolution after CFA interpolation of
> 1440x1080.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 48305ac481ed..e0086691a61e 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                                 { controls::draft::TestPatternModePn9, 4 },
>                         },
>                 } },
> +               { "imx296", {
> +                       .unitCellSize = { 3450, 3450 },
> +                       .testPatternModes = {},
> +               } },
>                 { "ov5647", {
>                         .unitCellSize = { 1400, 1400 },
>                         .testPatternModes = {},
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series

diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
index 48305ac481ed..e0086691a61e 100644
--- a/src/libcamera/camera_sensor_properties.cpp
+++ b/src/libcamera/camera_sensor_properties.cpp
@@ -90,6 +90,10 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 				{ controls::draft::TestPatternModePn9, 4 },
 			},
 		} },
+		{ "imx296", {
+			.unitCellSize = { 3450, 3450 },
+			.testPatternModes = {},
+		} },
 		{ "ov5647", {
 			.unitCellSize = { 1400, 1400 },
 			.testPatternModes = {},