| Message ID | 20211208094211.1251311-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 59644205705c3c96331479f9b6603fea90c87145 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush Thanks for this change. I agree that a bit less console-spamming is probably a good thing! On Wed, 8 Dec 2021 at 09:42, Naushir Patuck <naush@raspberrypi.com> wrote: > > Demote a couple of lines of logging to Debug level to reduce the verbosity of > the log output during startup. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks! David > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index 62db8f26b77d..4479e732a645 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -162,10 +162,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size & > bestFormat.size = size; > } > > - LOG(RPI, Info) << "Format: " << size.toString() > - << " fmt " << format.toString() > - << " Score: " << score > - << " (best " << bestScore << ")"; > + LOG(RPI, Debug) << "Format: " << size.toString() > + << " fmt " << format.toString() > + << " Score: " << score > + << " (best " << bestScore << ")"; > } > } > > @@ -1747,8 +1747,8 @@ void RPiCameraData::checkRequestCompleted() > state_ = State::Idle; > if (dropFrameCount_) { > dropFrameCount_--; > - LOG(RPI, Info) << "Dropping frame at the request of the IPA (" > - << dropFrameCount_ << " left)"; > + LOG(RPI, Debug) << "Dropping frame at the request of the IPA (" > + << dropFrameCount_ << " left)"; > } > } > } > -- > 2.25.1 >
Quoting Naushir Patuck (2021-12-08 09:42:10) > Demote a couple of lines of logging to Debug level to reduce the verbosity of > the log output during startup. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index 62db8f26b77d..4479e732a645 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -162,10 +162,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size & > bestFormat.size = size; > } > > - LOG(RPI, Info) << "Format: " << size.toString() > - << " fmt " << format.toString() > - << " Score: " << score > - << " (best " << bestScore << ")"; > + LOG(RPI, Debug) << "Format: " << size.toString() > + << " fmt " << format.toString() > + << " Score: " << score > + << " (best " << bestScore << ")"; > } > } > > @@ -1747,8 +1747,8 @@ void RPiCameraData::checkRequestCompleted() > state_ = State::Idle; > if (dropFrameCount_) { > dropFrameCount_--; > - LOG(RPI, Info) << "Dropping frame at the request of the IPA (" > - << dropFrameCount_ << " left)"; > + LOG(RPI, Debug) << "Dropping frame at the request of the IPA (" > + << dropFrameCount_ << " left)"; > } > } > } > -- > 2.25.1 >
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 62db8f26b77d..4479e732a645 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -162,10 +162,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size & bestFormat.size = size; } - LOG(RPI, Info) << "Format: " << size.toString() - << " fmt " << format.toString() - << " Score: " << score - << " (best " << bestScore << ")"; + LOG(RPI, Debug) << "Format: " << size.toString() + << " fmt " << format.toString() + << " Score: " << score + << " (best " << bestScore << ")"; } } @@ -1747,8 +1747,8 @@ void RPiCameraData::checkRequestCompleted() state_ = State::Idle; if (dropFrameCount_) { dropFrameCount_--; - LOG(RPI, Info) << "Dropping frame at the request of the IPA (" - << dropFrameCount_ << " left)"; + LOG(RPI, Debug) << "Dropping frame at the request of the IPA (" + << dropFrameCount_ << " left)"; } } }
Demote a couple of lines of logging to Debug level to reduce the verbosity of the log output during startup. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)