[libcamera-devel,1/2] lib: Include library in the install target

Message ID 20181126140111.13255-2-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • library install targets
Related show

Commit Message

Kieran Bingham Nov. 26, 2018, 2:01 p.m. UTC
The shared library build target does not install the library when 'ninja
install' is executed.

Flag it as an installable item.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 lib/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Nov. 27, 2018, 1:24 a.m. UTC | #1
Hi Kieran,

Thank you for the patch.

On Monday, 26 November 2018 16:01:10 EET Kieran Bingham wrote:
> The shared library build target does not install the library when 'ninja
> install' is executed.
> 
> Flag it as an installable item.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

I think this improves the usability of the installed library a lot, even if 
it's still not very useful yet :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  lib/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index 37876cee48ff..eee99b7525ce 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -2,4 +2,5 @@ sources = ['main.cpp']
> 
>  libcamera = shared_library('camera',
>  			   sources,
> +			   install : true,
>  			   include_directories : inc)

Patch

diff --git a/lib/meson.build b/lib/meson.build
index 37876cee48ff..eee99b7525ce 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -2,4 +2,5 @@  sources = ['main.cpp']
 
 libcamera = shared_library('camera',
 			   sources,
+			   install : true,
 			   include_directories : inc)